Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(angular-query): reorder query function declarations #7861

Merged
merged 1 commit into from
Aug 6, 2024
Merged

fix(angular-query): reorder query function declarations #7861

merged 1 commit into from
Aug 6, 2024

Conversation

arnoud-dv
Copy link
Collaborator

@arnoud-dv arnoud-dv commented Aug 6, 2024 •
edited
Loading

Applies fixes from #7260 to Angular Query.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Aug 6, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 96d9671. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 6, 2024 •
edited
Loading

commit: 96d9671

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@7861

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@7861

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@7861

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@7861

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@7861

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@7861

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@7861

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@7861

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@7861

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@7861

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@7861

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@7861

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@7861

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@7861

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@7861

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@7861

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@7861

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@7861

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@7861

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@7861

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@7861

Open in Stackblitz

More templates

@codecov Codecov
Copy link

codecov bot commented Aug 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.58%. Comparing base (1a1708b) to head (96d9671).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #7861       +/-   ##
=========================================
+ Coverage      0   86.58%   +86.58%     
=========================================
  Files         0       18       +18     
  Lines         0      231      +231     
  Branches      0       34       +34     
=========================================
+ Hits          0      200      +200     
- Misses        0       31       +31
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 86.58% <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@arnoud-dv arnoud-dv marked this pull request as draft August 6, 2024 18:58
@arnoud-dv arnoud-dv force-pushed the fix/reorder-query-function-declarations branch 2 times, most recently from 8b1cc33 to 13d9049 Compare August 6, 2024 20:10
@arnoud-dv arnoud-dv marked this pull request as ready for review August 6, 2024 20:13
@arnoud-dv arnoud-dv force-pushed the fix/reorder-query-function-declarations branch from 13d9049 to 96d9671 Compare August 6, 2024 20:17
@arnoud-dv arnoud-dv merged commit ed25a3f into TanStack:main Aug 6, 2024
8 checks passed
@arnoud-dv arnoud-dv deleted the fix/reorder-query-function-declarations branch August 6, 2024 20:27
@sadeghbarati sadeghbarati mentioned this pull request Aug 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: angular-query-experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@arnoud-dv