feat(queryCache): merge defaultConfig options #774
Conversation
Providing a `defaultConfig` to `makeQueryCache` will merge `shared`, `queries`, and `mutations` objects instead of overwriting. This allows you to configure only some options.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tannerlinsley/react-query/aafyjq3px |
|
|
||
| expect(() => queryCache.buildQuery('test')).not.toThrow( | ||
| 'config.queryKeySerializerFn is not a function' | ||
| ) |
There was a problem hiding this comment.
Open to suggestions on a better way to validate this -- I started by writing this test expecting the exception because that is the current behavior, switched to .not.toThrow and applied my code changes.
There was a problem hiding this comment.
I'm not sure either. But we can make it better in the future if we need to. If tests pass and you think this is good enough, then let me know and I'll merge :)
There was a problem hiding this comment.
If you're happy with it, the tests pass and it resolves the issue I was having :)
I had also considered exposing configRef on the queryCache but wasn't sure if increasing the public api to support testing was a good idea 🤔
There was a problem hiding this comment.
I'd rather not expose more api lol. I'm doing too much of that as it is.
|
🎉 This PR is included in version 2.5.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 participants
Providing a
defaultConfigtomakeQueryCachewill mergeshared,queries, andmutationsobjects instead of overwriting. This allows you to configure only some options.