Skip to content

fix(vue-query): Make queryKey watchers sync #5929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

markbrockhoff
Copy link
Contributor

@markbrockhoff markbrockhoff commented Aug 30, 2023

Make watchers of vue composables like useQuery sync to so changes to reactive variables inside the queryKey take effect immediately.

Closes #5910

@vercel
Copy link

vercel bot commented Aug 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2023 5:38am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 30, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8a32ed1:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@nx-cloud
Copy link

nx-cloud bot commented Aug 31, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8a32ed1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@markbrockhoff markbrockhoff changed the title fix(vue-query): Make queryKey watchers sync (#5910) fix(vue-query): Make queryKey watchers sync Aug 31, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage is 100.00% of modified lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Files Changed Coverage
packages/vue-query/src/useBaseQuery.ts 100.00%
packages/vue-query/src/useIsFetching.ts 100.00%
packages/vue-query/src/useIsMutating.ts 100.00%
packages/vue-query/src/useMutation.ts 100.00%
packages/vue-query/src/useQueries.ts 100.00%

📢 Thoughts on this report? Let us know!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue - Query key doesn't match the current value of ref used inside
3 participants