Skip to content

Conversation

@jbee37142
Copy link
Contributor

related pull request: #2556

Description

Change prevQuery to query in shouldFetchOptionally because of checking query key changed
situation.

Checking

  • Is refetch when query key changed without suspense? -> YES
  • Catch error in ErrorBoundary when query key changed and thrown error with error boundary? -> YES

Change `prevQuery` to `query` in `shouldFetchOptionally` because of checking query key changed
situation.
@vercel
Copy link

vercel bot commented Aug 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tannerlinsley/react-query/9qCuFj8uGL2DJmyBinUmUP9umejV
✅ Preview: https://react-query-git-fork-jaeyeophan-fix-should-52509c-tannerlinsley.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ab3724a:

Sandbox Source
tannerlinsley/react-query: basic Configuration
tannerlinsley/react-query: basic-typescript Configuration

@TkDodo TkDodo merged commit bac853f into TanStack:master Aug 12, 2021
@tannerlinsley
Copy link
Member

🎉 This PR is included in version 3.19.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jbee37142 jbee37142 deleted the fix/shouldFetchOptionally-condition-2 branch August 12, 2021 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants