Skip to content

Conversation

@orouz
Copy link
Contributor

@orouz orouz commented Apr 21, 2021

i think this is the correct type, as it's already defined just not used.

also without it, we can't do this:

const key = ['someKey'] as const // we don't want anyone mutating it
useMutation(fn,{ mutationKey: key }) // type error

@vercel
Copy link

vercel bot commented Apr 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tannerlinsley/react-query/95kPZzKrhHLhFxHfg91UBYmeB4vn
✅ Preview: https://react-query-git-fork-orouz-master-tannerlinsley.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fb6d89b:

Sandbox Source
tannerlinsley/react-query: basic Configuration
tannerlinsley/react-query: basic-typescript Configuration

@TkDodo TkDodo merged commit 5f73635 into TanStack:master Apr 21, 2021
@tannerlinsley
Copy link
Member

🎉 This PR is included in version 3.13.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants