Skip to content

Fix useInfiniteQuery suspense bug #2119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tannerlinsley merged 3 commits into from
Apr 15, 2021
Merged

Fix useInfiniteQuery suspense bug #2119

tannerlinsley merged 3 commits into from
Apr 15, 2021

Conversation

@flybayer
Copy link
Contributor

@flybayer flybayer commented Apr 13, 2021 •
edited
Loading

Closes: #2095

This fixes the useInfiniteQuery suspense bug where options.behavior was missing and so infiniteQueryBehavior.onFetch was not being called, resulting incorrect query data.

@vercel
Copy link

vercel bot commented Apr 13, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tannerlinsley/react-query/7VPS3U8EZsuUoa3L7RjcXX81fD5C
✅ Preview: https://react-query-git-fork-flybayer-2095-tannerlinsley.vercel.app

flybayer
flybayer commented Apr 13, 2021
View reviewed changes
src/react/tests/suspense.test.tsx
Comment on lines +106 to +108
expect(states.length).toBe(3)
expect(states[2]).toMatchObject({
data: { pages: [2], pageParams: [undefined] },
Copy link
Contributor Author

@flybayer flybayer Apr 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was surprising to me that states here is length 3 instead of 2, but I'm assuming this is expected.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 13, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3a3ecee:

Sandbox Source
tannerlinsley/react-query: basic Configuration
tannerlinsley/react-query: basic-typescript Configuration

@flybayer flybayer mentioned this pull request Apr 13, 2021
Closed
@boschni
Copy link
Collaborator

boschni commented Apr 14, 2021

Awesome! The behavior was indeed missing but should be added in InfiniteQueryObserver.getOptimisticResult so it will also be fixed for other frameworks

@flybayer
Copy link
Contributor Author

flybayer commented Apr 14, 2021

@boschni thanks! I pushed a commit that makes that change. Tests pass, but I had to do a type cast. Not sure if that's ok? If not, can you give some guidance on how to fix?

@boschni
Copy link
Collaborator

boschni commented Apr 14, 2021

lgtm!

@tannerlinsley tannerlinsley merged commit de28254 into TanStack:master Apr 15, 2021
@tannerlinsley
Copy link
Member

tannerlinsley commented Apr 15, 2021

🎉 This PR is included in version 3.13.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

useInfiniteQuery with suspense no longer returns pages (3.9.0+)

3 participants

@flybayer @boschni @tannerlinsley