Skip to content

Commit ffc7dc7

Browse files
perf(vue-query): remove redundant type wrappers (#6243)
1 parent 1e57af0 commit ffc7dc7

File tree

3 files changed

+14
-42
lines changed

3 files changed

+14
-42
lines changed

packages/vue-query/src/useBaseQuery.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ export type UseBaseQueryReturnType<
2929
| 'fetchNextPage'
3030
| 'fetchPreviousPage'
3131
| 'refetch'
32-
| 'remove'
3332
? Result[K]
3433
: ToRef<Readonly<Result>[K]>
3534
} & {

packages/vue-query/src/useInfiniteQuery.ts

Lines changed: 4 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,7 @@ import type {
1212

1313
import type { UseBaseQueryReturnType } from './useBaseQuery'
1414

15-
import type {
16-
DeepUnwrapRef,
17-
DistributiveOmit,
18-
MaybeRefDeep,
19-
MaybeRefOrGetter,
20-
} from './types'
15+
import type { DeepUnwrapRef, MaybeRefDeep, MaybeRefOrGetter } from './types'
2116
import type { QueryClient } from './queryClient'
2217

2318
export type UseInfiniteQueryOptions<
@@ -69,22 +64,11 @@ export type UseInfiniteQueryOptions<
6964
>
7065
}
7166

72-
type InfiniteQueryReturnType<TData, TError> = UseBaseQueryReturnType<
67+
export type UseInfiniteQueryReturnType<TData, TError> = UseBaseQueryReturnType<
7368
TData,
7469
TError,
7570
InfiniteQueryObserverResult<TData, TError>
7671
>
77-
export type UseInfiniteQueryReturnType<TData, TError> = DistributiveOmit<
78-
InfiniteQueryReturnType<TData, TError>,
79-
'fetchNextPage' | 'fetchPreviousPage' | 'refetch'
80-
> & {
81-
fetchNextPage: InfiniteQueryObserverResult<TData, TError>['fetchNextPage']
82-
fetchPreviousPage: InfiniteQueryObserverResult<
83-
TData,
84-
TError
85-
>['fetchPreviousPage']
86-
refetch: InfiniteQueryObserverResult<TData, TError>['refetch']
87-
}
8872

8973
export function useInfiniteQuery<
9074
TQueryFnData,
@@ -103,11 +87,9 @@ export function useInfiniteQuery<
10387
>,
10488
queryClient?: QueryClient,
10589
): UseInfiniteQueryReturnType<TData, TError> {
106-
const result = useBaseQuery(
90+
return useBaseQuery(
10791
InfiniteQueryObserver as typeof QueryObserver,
10892
options,
10993
queryClient,
110-
) as InfiniteQueryReturnType<TData, TError>
111-
112-
return result
94+
) as UseInfiniteQueryReturnType<TData, TError>
11395
}

packages/vue-query/src/useQuery.ts

Lines changed: 10 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,15 @@
11
import { QueryObserver } from '@tanstack/query-core'
22
import { useBaseQuery } from './useBaseQuery'
3-
import type { ToRefs } from 'vue-demi'
43
import type {
54
DefaultError,
65
DefinedQueryObserverResult,
76
QueryKey,
87
QueryObserverOptions,
9-
QueryObserverResult,
108
WithRequired,
119
} from '@tanstack/query-core'
1210
import type { UseBaseQueryReturnType } from './useBaseQuery'
1311
import type {
1412
DeepUnwrapRef,
15-
DistributiveOmit,
1613
MaybeRef,
1714
MaybeRefDeep,
1815
MaybeRefOrGetter,
@@ -86,20 +83,16 @@ export type DefinedInitialQueryOptions<
8683
| (() => NonUndefinedGuard<TQueryFnData>)
8784
}
8885

89-
export type UseQueryReturnType<TData, TError> = DistributiveOmit<
90-
UseBaseQueryReturnType<TData, TError>,
91-
'refetch'
92-
> & {
93-
refetch: QueryObserverResult<TData, TError>['refetch']
94-
}
86+
export type UseQueryReturnType<TData, TError> = UseBaseQueryReturnType<
87+
TData,
88+
TError
89+
>
9590

96-
export type UseQueryDefinedReturnType<TData, TError> = DistributiveOmit<
97-
ToRefs<Readonly<DefinedQueryObserverResult<TData, TError>>>,
98-
'refetch'
99-
> & {
100-
suspense: () => Promise<QueryObserverResult<TData, TError>>
101-
refetch: QueryObserverResult<TData, TError>['refetch']
102-
}
91+
export type UseQueryDefinedReturnType<TData, TError> = UseBaseQueryReturnType<
92+
TData,
93+
TError,
94+
DefinedQueryObserverResult<TData, TError>
95+
>
10396

10497
export function useQuery<
10598
TQueryFnData = unknown,
@@ -154,7 +147,5 @@ export function useQuery<
154147
):
155148
| UseQueryReturnType<TData, TError>
156149
| UseQueryDefinedReturnType<TData, TError> {
157-
const result = useBaseQuery(QueryObserver, options, queryClient)
158-
159-
return result
150+
return useBaseQuery(QueryObserver, options, queryClient)
160151
}

0 commit comments

Comments
 (0)