Skip to content

Commit 80e82da

Browse files
committed
fix: cancelQueries now uses the query.cancel method
fix: query.cancelQueries was renamed to query.cancelPromises
1 parent 3ef9c7c commit 80e82da

File tree

1 file changed

+17
-14
lines changed

1 file changed

+17
-14
lines changed

src/queryCache.js

Lines changed: 17 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -124,11 +124,7 @@ export function makeQueryCache() {
124124
const foundQueries = findQueries(predicate, { exact })
125125

126126
foundQueries.forEach(query => {
127-
query.cancelled = cancelledError
128-
129-
if (query.cancelQueries) {
130-
query.cancelQueries()
131-
}
127+
query.cancel()
132128
})
133129

134130
if (foundQueries.length) {
@@ -327,6 +323,18 @@ export function makeQueryCache() {
327323
query.cancelled = null
328324
}
329325

326+
query.cancel = () => {
327+
query.cancelled = cancelledError
328+
329+
if (query.cancelPromises) {
330+
query.cancelPromises()
331+
}
332+
333+
delete query.promise
334+
335+
notifyGlobalListeners()
336+
}
337+
330338
query.updateInstance = instance => {
331339
let found = query.instances.find(d => d.id === instance.id)
332340

@@ -349,12 +357,7 @@ export function makeQueryCache() {
349357
query.instances = query.instances.filter(d => d.id !== instanceId)
350358

351359
if (!query.instances.length) {
352-
// Cancel any side-effects
353-
query.cancelled = cancelledError
354-
355-
if (query.cancelQueries) {
356-
query.cancelQueries()
357-
}
360+
query.cancel()
358361

359362
// Schedule garbage collection
360363
query.scheduleGarbageCollection()
@@ -368,16 +371,16 @@ export function makeQueryCache() {
368371
// Perform the query
369372
const promise = queryFn(...query.config.queryFnParamsFilter(args))
370373

371-
query.cancelQueries = () => promise.cancel?.()
374+
query.cancelPromises = () => promise.cancel?.()
372375

373376
const data = await promise
374377

375-
delete query.cancelQueries
378+
delete query.cancelPromises
376379
if (query.cancelled) throw query.cancelled
377380

378381
return data
379382
} catch (error) {
380-
delete query.cancelQueries
383+
delete query.cancelPromises
381384
if (query.cancelled) throw query.cancelled
382385

383386
// If we fail, increase the failureCount

0 commit comments

Comments
 (0)