v1.2.2

Author: tannerlinsley

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 1.2.2
+
+- Fixed an issue where garbage collection was messing with proper test cleanup
+- Fixed an issue where tests were giving false positives because of the above
+- Fixed an issue where query creation during the render phase was eventually triggering setState (found via a cache subscription in the `useIsFetching` hook, when used in the same parent component as a query)
+
 ## 1.2.1
 
 - Fixed an issue where the `throwOnError` option was not working for `queryCache.prefetchQuery`

media/logo.sketch

@@ -1,6 +1,6 @@
 {
   "name": "react-query",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "description": "Hooks for managing, caching and syncing asynchronous and remote data in React",
   "author": "tannerlinsley",
   "license": "MIT",

package.json

@@ -134,7 +134,12 @@ export function makeQueryCache() {
       if (query.queryHash) {
         if (!isServer) {
           cache.queries[queryHash] = query
-          notifyGlobalListeners()
+          // Here, we setTimeout so as to not trigger
+          // any setState's in parent components in the
+          // middle of the render phase.
+          setTimeout(() => {
+            notifyGlobalListeners()
+          })
         }
       }
     }
@@ -243,7 +248,9 @@ export function makeQueryCache() {
       query.cacheTimeout = setTimeout(
         () => {
           cache.removeQueries(
-            d => d.state.markedForGarbageCollection && d.queryHash === query.queryHash
+            d =>
+              d.state.markedForGarbageCollection &&
+              d.queryHash === query.queryHash
           )
         },
         typeof query.state.data === 'undefined' &&