chore(deps): remove execa direct dependency #4854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
Bumps [execa](https://github.com/sindresorhus/execa) from 4.1.0 to 8.0.1. - [Release notes](https://github.com/sindresorhus/execa/releases) - [Commits](sindresorhus/execa@v4.1.0...v8.0.1) --- updated-dependencies: - dependency-name: execa dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/execa-8.0.1
branch
from
61384de to
d2307fd
Compare
romainseb
temporarily deployed
to
pull_request_unsafe
GitHub Actions
Inactive
romainseb
had a problem deploying
to
pull_request_unsafe
GitHub Actions
Failure
romainseb
had a problem deploying
to
pull_request_unsafe
GitHub Actions
Failure
romainseb
had a problem deploying
to
pull_request_unsafe
GitHub Actions
Failure
romainseb
had a problem deploying
to
pull_request_unsafe
GitHub Actions
Failure
romainseb
removed
dependencies
romainseb
temporarily deployed
to
pull_request_unsafe
GitHub Actions
Inactive
romainseb
had a problem deploying
to
pull_request_unsafe
GitHub Actions
Error
romainseb
had a problem deploying
to
pull_request_unsafe
GitHub Actions
Error
romainseb
had a problem deploying
to
pull_request_unsafe
GitHub Actions
Error
romainseb
had a problem deploying
to
pull_request_unsafe
GitHub Actions
Error
romainseb
temporarily deployed
to
pull_request_unsafe
GitHub Actions
Inactive
romainseb
temporarily deployed
to
pull_request_unsafe
GitHub Actions
Inactive
romainseb
temporarily deployed
to
pull_request_unsafe
GitHub Actions
Inactive
romainseb
temporarily deployed
to
pull_request_unsafe
GitHub Actions
Inactive
romainseb
temporarily deployed
to
pull_request_unsafe
GitHub Actions
Inactive
|
A newer version of execa exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
🦋 Changeset detectedLatest commit: 3c56f93 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jmfrancois
had a problem deploying
to
pull_request_unsafe
GitHub Actions
Error
jmfrancois
temporarily deployed
to
pull_request_unsafe
GitHub Actions
Inactive
jmfrancois
reviewed
Jul 29, 2025
fork/module-to-cdn/cache.js
Outdated
Comment on lines
13
to
15
| import('execa').then(({default: execaModule}) => { | ||
| execa = execaModule; | ||
| }); |
There was a problem hiding this comment.
I dont' see any default in it 🤔
> import('execa').then(mod => console.log(mod))
Promise {
<pending>,
[Symbol(async_id_symbol)]: 2448,
[Symbol(trigger_async_id_symbol)]: 2440
}
> [Module: null prototype] {
'$': [Function: $] { sync: [Function (anonymous)] },
execa: [Function: execa],
execaCommand: [Function: execaCommand],
execaCommandSync: [Function: execaCommandSync],
execaNode: [Function: execaNode],
execaSync: [Function: execaSync]
}
> import('execa').then(mod => console.log(mod.execa))
Promise {
<pending>,
[Symbol(async_id_symbol)]: 2527,
[Symbol(trigger_async_id_symbol)]: 2519
}
> [Function: execa]
|
Storybook for this PR deployed on this github page |
jmfrancois
temporarily deployed
to
pull_request_unsafe
GitHub Actions
Inactive
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jmfrancois
requested changes
Jul 29, 2025
jmfrancois
temporarily deployed
to
pull_request_unsafe
GitHub Actions
Inactive
jmfrancois
approved these changes
Jul 29, 2025
jmfrancois
changed the title
| @@ -124,7 +123,8 @@ | |||
| ensureCacheFolderExists(); | |||
|
|
|||
| if (!CACHE_NPM[moduleName]) { | |||
| const info = JSON.parse(execa.sync('npm', ['info', '--json', `${moduleName}`]).stdout); | |||
| const stdout = child.execSync(`npm info --json ${moduleName}`, {encoding: 'utf8'}); | |||
Check warning
Code scanning / CodeQL
Unsafe shell command constructed from library input Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 2 days ago
To fix this issue, we should avoid passing untrusted input directly to the shell. Instead of using child.execSync with a string command, we should use child.execFileSync, which takes the command and its arguments as separate parameters, bypassing the shell and preventing command injection. Specifically, we should replace child.execSync(`npm info --json ${moduleName}`, {encoding: 'utf8'}) with child.execFileSync('npm', ['info', '--json', moduleName], {encoding: 'utf8'}). This change should be made in the getModuleInfo function in fork/module-to-cdn/cache.js. No additional imports are needed, as child_process is already imported as child.
Suggested changeset
1
fork/module-to-cdn/cache.js
| @@ -125,3 +125,3 @@ | ||
| if (!CACHE_NPM[moduleName]) { | ||
| const stdout = child.execSync(`npm info --json ${moduleName}`, {encoding: 'utf8'}); | ||
| const stdout = child.execFileSync('npm', ['info', '--json', moduleName], {encoding: 'utf8'}); | ||
| const info = JSON.parse(stdout); |
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps execa from 4.1.0 to 8.0.1.
Release notes
Sourced from execa's releases.
... (truncated)
Commits
f4b8b3a8.0.189c69feSupport{encoding: 'buffer'}(#572)e7dee288.0.088ee3bdUpgradeget-stream(#571)f31fbdbFix documentation typo (#568)468fbe1Upgradesignal-exitto v4 (#570)65992b4Require Node.js 16 (#569)db580857.2.0f57fdecAddcwderror property (#565)a228edaMeta tweaksYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)