-
Notifications
You must be signed in to change notification settings - Fork 50
chore(QTDI-1553): migrate from osshr to central #1068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the project’s Maven configuration to use Sonatype Central Portal instead of OSSRH, swaps out the Nexus staging plugin for the central-publishing plugin, and aligns Jenkins credentials.
- Replace all OSSRH endpoints and plugin IDs with central.sonatype.com URLs and
central-publishing-maven-plugin
. - Add Cloudera public plugin repository and update Jenkins server ID to
central.portal
. - Remove explicit release repository in favor of plugin defaults (per inline comment).
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
pom.xml | Switched distributionManagement and repositories to central portal URLs; replaced nexus-staging plugin with central-publishing plugin; added Cloudera public pluginRepository. |
.jenkins/settings.xml | Changed server <id> from ossrh to central.portal for Jenkins credentials. |
Comments suppressed due to low confidence (3)
pom.xml:139
- [nitpick] This inline comment is vague; consider clarifying which plugin features automatically handle releases and snapshots or remove it if no longer needed.
<!-- looks like release and snapshot plugins are handled by sonatype plugin from the box -->
.jenkins/settings.xml:8
- [nitpick] The server ID
central.portal
no longer matches theOSSRH_*
environment variable names; consider renaming the env vars or adding documentation so credentials map correctly.
<id>central.portal</id>
pom.xml:139
- The
<repository>
section for releases was removed—ensure you explicitly declare a<repository>
for releases or verify thatcentral-publishing-maven-plugin
will publish releases correctly to avoid deployment failures.
<!-- looks like release and snapshot plugins are handled by sonatype plugin from the box -->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left question.
Will 👁️ for any other may miss.
@@ -942,11 +940,12 @@ | |||
|
|||
<repositories> | |||
<repository> | |||
<id>central-portal-snapshots</id> | |||
<name>Central Portal Snapshots</name> | |||
<url>https://central.sonatype.com/repository/maven-snapshots/</url> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see releases
also I think...
<id>Cloudera.pub</id> | ||
<url>https://repository.cloudera.com/content/repositories/public</url> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cloudera for releases? (see my previous comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cloudera is to load maven plug-in. The new is placed there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I didn't understand this comment.
Found some extra references to sonatype.org: Lines 473 to 474 in 6661911
component-runtime/sample-parent/documentation-sample/_src/build/Bundles.groovy Lines 124 to 125 in da88e58
Also in master pom.xml. Also, did not checked if still mirrored (I think so), check maybe all references to repo.maven.apache.org Line 154 in da88e58
|
This comment has been minimized.
This comment has been minimized.
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
94f94a3
to
4c39c23
Compare
Requirements
https://qlik-dev.atlassian.net/browse/QTDI-1553
Why this PR is needed?
What does this PR adds (design/code thoughts)?