Skip to content

chore(QTDI-1553): migrate from osshr to central #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ozhelezniak-talend
Copy link
Contributor

@ozhelezniak-talend ozhelezniak-talend commented Jun 26, 2025

Requirements

https://qlik-dev.atlassian.net/browse/QTDI-1553

Why this PR is needed?

What does this PR adds (design/code thoughts)?

This comment has been minimized.

1 similar comment

This comment has been minimized.

This comment has been minimized.

Copilot

This comment was marked as outdated.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the project’s Maven configuration to use Sonatype Central Portal instead of OSSRH, swaps out the Nexus staging plugin for the central-publishing plugin, and aligns Jenkins credentials.

  • Replace all OSSRH endpoints and plugin IDs with central.sonatype.com URLs and central-publishing-maven-plugin.
  • Add Cloudera public plugin repository and update Jenkins server ID to central.portal.
  • Remove explicit release repository in favor of plugin defaults (per inline comment).

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
pom.xml Switched distributionManagement and repositories to central portal URLs; replaced nexus-staging plugin with central-publishing plugin; added Cloudera public pluginRepository.
.jenkins/settings.xml Changed server <id> from ossrh to central.portal for Jenkins credentials.
Comments suppressed due to low confidence (3)

pom.xml:139

  • [nitpick] This inline comment is vague; consider clarifying which plugin features automatically handle releases and snapshots or remove it if no longer needed.
    <!-- looks like release and snapshot plugins are handled by sonatype plugin from the box -->

.jenkins/settings.xml:8

  • [nitpick] The server ID central.portal no longer matches the OSSRH_* environment variable names; consider renaming the env vars or adding documentation so credentials map correctly.
      <id>central.portal</id>

pom.xml:139

  • The <repository> section for releases was removed—ensure you explicitly declare a <repository> for releases or verify that central-publishing-maven-plugin will publish releases correctly to avoid deployment failures.
    <!-- looks like release and snapshot plugins are handled by sonatype plugin from the box -->

Copy link
Member

@undx undx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left question.
Will 👁️ for any other may miss.

@@ -942,11 +940,12 @@

<repositories>
<repository>
<id>central-portal-snapshots</id>
<name>Central Portal Snapshots</name>
<url>https://central.sonatype.com/repository/maven-snapshots/</url>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see releases also I think...

Comment on lines +1007 to +1011
<id>Cloudera.pub</id>
<url>https://repository.cloudera.com/content/repositories/public</url>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cloudera for releases? (see my previous comment).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cloudera is to load maven plug-in. The new is placed there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I didn't understand this comment.

@undx
Copy link
Member

undx commented Jun 26, 2025

Found some extra references to sonatype.org:

repo = ['oss.sonatype.org',
'https://oss.sonatype.org/content/repositories/snapshots/org/talend/sdk/component/']

def snapshotLink = "https://oss.sonatype.org/service/local/artifact/maven/content?r=snapshots&g=org.talend.sdk.component&a=documentation-sample&v=${project.version}&e=zip&c=${it}-distribution"
def releaseLink = "https://repo.maven.apache.org/maven2/org/talend/sdk/component/documentation-sample/${project.version.replace('-SNAPSHOT', '')}/documentation-sample-${project.version.replace('-SNAPSHOT', '')}-${it}-distribution.zip"

Also in master pom.xml.

Also, did not checked if still mirrored (I think so), check maybe all references to repo.maven.apache.org

.target("https://repo.maven.apache.org/maven2/org/talend/sdk/component/component-starter-server/");

This comment has been minimized.

3 similar comments

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@ozhelezniak-talend ozhelezniak-talend force-pushed the ozhelezniak/QTDI-1553_nexus_central branch from 94f94a3 to 4c39c23 Compare June 27, 2025 09:41
Copy link

sonar-eks bot commented Jun 27, 2025

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (65.80% Estimated after merge)
  • Duplications 0.00% Duplicated Code (1.30% Estimated after merge)

Project ID: org.talend.sdk.component:component-runtime

View in SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants