Open
Conversation
…olt/takepod into missing-data-token � Conflicts: � takepod/datasets/iterator.py � takepod/storage/field.py � test/storage/test_iterator.py
…olt/takepod into missing-data-token
…tenceEmbeddingField # Conflicts: # takepod/datasets/iterator.py # takepod/examples/ner_example.py # takepod/storage/field.py # takepod/storage/vocab.py # test/storage/test_field.py # test/storage/test_iterator.py # test/storage/test_vocab.py
FilipBolt
approved these changes
Apr 3, 2020
…beddingField � Conflicts: � test/storage/test_field.py
FilipBolt
approved these changes
Apr 29, 2020
Collaborator
|
This PR looks a bit outdated at this point. However, I'd like to have this functionality easily integrated in the NumericalizerABC interface. @ivansmokovic Would you be comfortable with discarding this? I don't see SentenceEmbedding in this form long term, as I believe we need some general free-form input-output contract such that we can transform a single token to a single number, multiple tokens to a single number and multiple tokens to a single number (vector) (SentenceEmbedding case) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Sentence embedding field