-
-
Notifications
You must be signed in to change notification settings - Fork 441
fix: tests were overwriting the settings.toml #928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tests were overwriting the settings.toml #928
Conversation
|
I'm still having my settings.toml file reset to the default on my machine: Before running tests: language = "en"
open_last_loaded_on_startup = false
autoplay = true
loop = true
show_filenames_in_grid = true
page_size = 1000
show_filepath = 1
theme = 2
date_format = "%Y-%m-%d"
hour_format = true
zero_padding = trueAfter running tests: language = "en"
open_last_loaded_on_startup = true
autoplay = true
loop = true
show_filenames_in_grid = true
page_size = 100
show_filepath = 1
theme = 2
date_format = "%x"
hour_format = true
zero_padding = trueIt's worth noting that #903 affected #927 in some way by writing the internal test values to the settings.toml instead of resetting the values to their defaults, but in either case it's not an intended behavior. I also had merged #903 into |
|
Fixed |
CyanVoxel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working on macOS and Windows, thank you for the fix!
Summary
Fix #927 by defaulting to the location a
GlobalSettingsobject was read from when callingsavewithout path.Tasks Completed