Skip to content

Conversation

@Computerdores
Copy link
Collaborator

Summary

Fix #927 by defaulting to the location a GlobalSettings object was read from when calling save without path.

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@Computerdores Computerdores moved this to 🏓 Ready for Review in TagStudio Development May 5, 2025
@CyanVoxel CyanVoxel added Type: Bug Something isn't working as intended Type: Tests Tests or testing related Priority: Medium An issue that shouldn't be be saved for last labels May 5, 2025
@CyanVoxel CyanVoxel moved this from 🏓 Ready for Review to 👀 In review in TagStudio Development May 5, 2025
@CyanVoxel
Copy link
Member

I'm still having my settings.toml file reset to the default on my machine:

Before running tests:

language = "en"
open_last_loaded_on_startup = false
autoplay = true
loop = true
show_filenames_in_grid = true
page_size = 1000
show_filepath = 1
theme = 2
date_format = "%Y-%m-%d"
hour_format = true
zero_padding = true

After running tests:

language = "en"
open_last_loaded_on_startup = true
autoplay = true
loop = true
show_filenames_in_grid = true
page_size = 100
show_filepath = 1
theme = 2
date_format = "%x"
hour_format = true
zero_padding = true

It's worth noting that #903 affected #927 in some way by writing the internal test values to the settings.toml instead of resetting the values to their defaults, but in either case it's not an intended behavior.

I also had merged #903 into main instead of the Alpha-v9.5.3 branch (which touches similar code) since it was workflow related and not feature related, sorry for the confusion with these branches

@Computerdores
Copy link
Collaborator Author

Fixed

Copy link
Member

@CyanVoxel CyanVoxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on macOS and Windows, thank you for the fix!

@CyanVoxel CyanVoxel moved this from 👀 In review to 🍃 Pending Merge in TagStudio Development May 5, 2025
@CyanVoxel CyanVoxel merged commit d061e2e into TagStudioDev:Alpha-v9.5.3 May 5, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from 🍃 Pending Merge to ✅ Done in TagStudio Development May 5, 2025
@CyanVoxel CyanVoxel linked an issue May 5, 2025 that may be closed by this pull request
3 tasks
@Computerdores Computerdores deleted the fix/overwrite_settings_bug branch July 6, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Medium An issue that shouldn't be be saved for last Type: Bug Something isn't working as intended Type: Tests Tests or testing related

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

[Bug]: Running Tests Overwrites settings.toml Values

2 participants