Skip to content

fix(ui): seamlessly loop videos #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged

fix(ui): seamlessly loop videos #902

merged 1 commit into from
Mar 31, 2025

Conversation

CyanVoxel
Copy link
Member

Summary

This PR replaces the manual video looping logic with the QMediaPlayer.setLoops() method to seamlessly loop videos instead of stopping and starting them again.

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@CyanVoxel CyanVoxel added Type: Bug Something isn't working as intended Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience Priority: Medium An issue that shouldn't be be saved for last labels Mar 31, 2025
@CyanVoxel CyanVoxel added this to the Alpha v9.5.2 milestone Mar 31, 2025
@CyanVoxel CyanVoxel merged commit f88200f into main Mar 31, 2025
10 checks passed
@CyanVoxel CyanVoxel deleted the seamless-loop branch March 31, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium An issue that shouldn't be be saved for last Type: Bug Something isn't working as intended Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

1 participant