Skip to content

fix: Remove border from video preview top and left #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

zfbx
Copy link
Contributor

@zfbx zfbx commented Mar 31, 2025

Summary

made the border on the video preview none to remove the grey lines on the left and top of the video preview to keep with how it looked before the refactor

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@zfbx zfbx changed the title Remove border from video preview top and left fix: Remove border from video preview top and left Mar 31, 2025
Copy link
Collaborator

@Computerdores Computerdores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a definite improvement and can be merged in my opinion.

Would you be interested in also adjusting the alignment of the play time indicator in the bottom left to fit the rest of the UI elements? If not that could just be done in a separate PR

Before this PR:
image
After this PR:
image

@CyanVoxel CyanVoxel added Type: Bug Something isn't working as intended Type: UI/UX User interface and/or user experience labels Mar 31, 2025
@CyanVoxel CyanVoxel moved this to 👀 In review in TagStudio Development Mar 31, 2025
@CyanVoxel CyanVoxel moved this from 👀 In review to 🍃 Pending Merge in TagStudio Development Mar 31, 2025
@CyanVoxel CyanVoxel added this to the Alpha v9.5.2 milestone Mar 31, 2025
@CyanVoxel CyanVoxel merged commit cccd858 into TagStudioDev:main Mar 31, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from 🍃 Pending Merge to ✅ Done in TagStudio Development Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as intended Type: UI/UX User interface and/or user experience
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants