Skip to content

feat: improve responsiveness of GIF entries #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Computerdores
Copy link
Collaborator

@Computerdores Computerdores commented Mar 29, 2025

Summary

Improves responsiveness of opening GIF entry by passing file path directly to QMovie instead of opening the image and copying it twice.

Fixes #816.

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality (GIF, APNG, WEBP)
    • PyInstaller executable

@Computerdores Computerdores moved this to 🏓 Ready for Review in TagStudio Development Mar 29, 2025
@Computerdores Computerdores added Type: UI/UX User interface and/or user experience Status: Review Needed A review of this is needed Type: Performance An issue or change related to performance labels Mar 29, 2025
@Computerdores Computerdores marked this pull request as draft March 29, 2025 16:07
@Computerdores Computerdores removed the Status: Review Needed A review of this is needed label Mar 29, 2025
@Computerdores Computerdores marked this pull request as ready for review March 29, 2025 16:45
@Computerdores Computerdores added the Status: Review Needed A review of this is needed label Mar 29, 2025
@CyanVoxel CyanVoxel moved this from 🏓 Ready for Review to 👀 In review in TagStudio Development Mar 29, 2025
@CyanVoxel CyanVoxel added this to the Alpha v9.5.2 milestone Mar 29, 2025
@CyanVoxel CyanVoxel added Priority: High An important issue requiring attention and removed Status: Review Needed A review of this is needed labels Mar 30, 2025
@CyanVoxel CyanVoxel moved this from 👀 In review to 🍃 Pending Merge in TagStudio Development Mar 30, 2025
Copy link
Member

@CyanVoxel CyanVoxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome fix! Tested on macOS+SSD, Windows+HDD, and NixOS and haven't run into any regressions.

@CyanVoxel CyanVoxel merged commit e3b2eaf into TagStudioDev:main Mar 31, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from 🍃 Pending Merge to ✅ Done in TagStudio Development Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High An important issue requiring attention Type: Performance An issue or change related to performance Type: UI/UX User interface and/or user experience
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Bug]: The app freezes when clicking on a GIF image
2 participants