Skip to content

fix(flake): remove pinned input, only consume in Nix shell #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

xarvex
Copy link
Member

@xarvex xarvex commented Mar 16, 2025

Summary

Resolves problem of duplicated nixpkgs input as noted in #847 (comment), will now only be consumed by the Nix shell.

Long term, an alternative like uv2nix could be used in the shell to remove any kind of pinning. That is out of scope for now, especially when there is no lock file being used in the repo yet.

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86 (NixOS)
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@xarvex xarvex mentioned this pull request Mar 16, 2025
3 tasks
@CyanVoxel CyanVoxel added Type: Bug Something isn't working as intended Type: Installation Installing, building, and/or launching the program System: Linux For Linux/BSD distributions Status: Mergeable The code is ready to be merged labels Mar 17, 2025
@CyanVoxel CyanVoxel added this to the Alpha v9.5.2 milestone Mar 17, 2025
@CyanVoxel CyanVoxel merged commit 010a452 into main Mar 18, 2025
10 checks passed
@CyanVoxel CyanVoxel deleted the nixpkgs-pin branch March 18, 2025 01:36
@CyanVoxel CyanVoxel removed the Status: Mergeable The code is ready to be merged label Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
System: Linux For Linux/BSD distributions Type: Bug Something isn't working as intended Type: Installation Installing, building, and/or launching the program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants