Skip to content

fix: catch NotImplementedError for Float16 JPEG-XL files #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Conversation

CyanVoxel
Copy link
Member

Summary

Resolves #848 by catching the NotImplementedError raised by attempting to render "Float16" JPEG-XL files, which are not currently supported by the pillow_jxl module.

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@CyanVoxel CyanVoxel added Type: Bug Something isn't working as intended Type: UI/UX User interface and/or user experience Priority: Medium An issue that shouldn't be be saved for last Status: Blocked This issue or pull request is awaiting the outcome of another issue or pull request labels Mar 8, 2025
@CyanVoxel CyanVoxel added this to the Alpha v9.5.2 milestone Mar 8, 2025
@CyanVoxel CyanVoxel removed the Status: Blocked This issue or pull request is awaiting the outcome of another issue or pull request label Mar 10, 2025
@CyanVoxel CyanVoxel moved this to 🍃 Pending Merge in TagStudio Development Mar 10, 2025
@CyanVoxel CyanVoxel merged commit 8c90f21 into main Mar 10, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from 🍃 Pending Merge to ✅ Done in TagStudio Development Mar 10, 2025
@CyanVoxel CyanVoxel deleted the fix-848 branch March 10, 2025 07:58
csponge pushed a commit to csponge/TagStudio that referenced this pull request Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium An issue that shouldn't be be saved for last Type: Bug Something isn't working as intended Type: UI/UX User interface and/or user experience
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Bug]: JPEG-XL with 16-bit float breaks basic functionality
1 participant