Skip to content

fix: refactor and fix bugs with missing_files.py #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 28, 2025
Merged

Conversation

CyanVoxel
Copy link
Member

This PR extends the fixes added in #720, which was an extension of #653, and makes the following additional changes:

  • Refactors missing_files.py with more consistent an unambiguous naming
  • Fixes a bug where a loop would try to remove an item from the list it was iterating over, resulting in matched results being skipped each loop
  • Fixed a test that was built with the above issue present
  • Uses the GLOBAL_IGNORE_SET as part of the file matching process

@CyanVoxel CyanVoxel added Type: Bug Something isn't working as intended Type: Refactor Code that needs to be restructured or cleaned up TagStudio: Library Relating to the TagStudio library system labels Jan 28, 2025
@CyanVoxel CyanVoxel added this to the SQL Parity milestone Jan 28, 2025
@CyanVoxel CyanVoxel merged commit 20d788a into main Jan 28, 2025
10 checks passed
@CyanVoxel CyanVoxel deleted the fix-unlinked-again branch January 28, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TagStudio: Library Relating to the TagStudio library system Type: Bug Something isn't working as intended Type: Refactor Code that needs to be restructured or cleaned up
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants