Skip to content

fix: sort tag results #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Conversation

mashed5894
Copy link
Contributor

@mashed5894 mashed5894 commented Jan 23, 2025

fix for #687. added logic to sort the results of a tag search. currently prioritizing results that start with the correct string and sorting them by length, and then sorting all other results alphabetically. saw the todo comment, but i could not figure out a simple way of reusing the widgets, theyd probably have to be stored in a dict between updates or something.

@CyanVoxel CyanVoxel added Type: Bug Something isn't working as intended Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience Priority: High An important issue requiring attention TagStudio: Tags Relating to the TagStudio tag system TagStudio: Search The TagStudio search engine labels Jan 23, 2025
@CyanVoxel CyanVoxel added this to the SQL Parity milestone Jan 23, 2025
@mashed5894 mashed5894 marked this pull request as ready for review January 23, 2025 03:13
Copy link
Member

@CyanVoxel CyanVoxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work on this, thank you so much for the fix!

@CyanVoxel CyanVoxel linked an issue Jan 23, 2025 that may be closed by this pull request
3 tasks
@CyanVoxel CyanVoxel merged commit 17c6280 into TagStudioDev:main Jan 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High An important issue requiring attention TagStudio: Search The TagStudio search engine TagStudio: Tags Relating to the TagStudio tag system Type: Bug Something isn't working as intended Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Bug]: Regression: 'Add Tags' search result is no longer ordered by exactness
2 participants