Skip to content

fix: don't add default title field, use proper phrasing for adding files #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

CyanVoxel
Copy link
Member

Summary

This PR makes a couple changes to the experience of adding new file entries:

  1. A default "Title" field is no longer added to new file entries that are added to a library. This was discussed as a positive change in SQLite DB with SQLAlchemy II #332, however since the removal of tag fields in feat!: tag categories #655 it's been strange to only have the default title field remain from this original decision.
    • NOTE: The DB currently has an is_default column for the value_type table which was used for this original choice. This is likely no longer needed, but its purpose should be decided once users are allowed to set their own preferred default fields (which is out of the scope of this PR).
  2. The terminology used when adding files has been changed from talking about "running macros" to "adding files". This is especially important since most of the time spent during this operation is simply adding the new entries to the database, rather than "running configured macros".

@CyanVoxel CyanVoxel added Type: Bug Something isn't working as intended Type: Translations Modifies translation keys or translation capabilities. Priority: Medium An issue that shouldn't be be saved for last labels Jan 13, 2025
@CyanVoxel CyanVoxel added this to the SQL Parity milestone Jan 13, 2025
@CyanVoxel CyanVoxel added the Status: Review Needed A review of this is needed label Jan 13, 2025
@Computerdores Computerdores removed the Status: Review Needed A review of this is needed label Jan 19, 2025
@CyanVoxel CyanVoxel merged commit 16fb029 into main Jan 22, 2025
10 checks passed
@CyanVoxel CyanVoxel deleted the fix-startup-macros branch January 22, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium An issue that shouldn't be be saved for last Type: Bug Something isn't working as intended Type: Translations Modifies translation keys or translation capabilities.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants