Skip to content

feat: Sorting by "Date Added" #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 10, 2025

Conversation

Computerdores
Copy link
Collaborator

@Computerdores Computerdores commented Dec 30, 2024

Implements sorting by "Date Added" and adds it to the Roadmap for 9.5 as it was missing there.

Note: "Date Added" refers to when the file was added to the Library

@Computerdores Computerdores added Type: Enhancement New feature or request Priority: High An important issue requiring attention TagStudio: Search The TagStudio search engine labels Dec 30, 2024
@Computerdores Computerdores changed the title feat: Sortable Results feat: Sorting by "Date Created" Dec 30, 2024
@Computerdores Computerdores added the Status: Review Needed A review of this is needed label Dec 30, 2024
@Computerdores Computerdores added this to the Alpha v9.5 (Post-SQL) milestone Dec 30, 2024
@Computerdores Computerdores marked this pull request as ready for review December 30, 2024 20:18
@Computerdores
Copy link
Collaborator Author

I'm not implementing the other sorting modes here because they all require much more in depth changes, meaning they will take longer to implement and review, and having just this would already be nice for 9.5

@CyanVoxel
Copy link
Member

Ahhh, in the roadmap by "date created" and "date modified" I was referring to the file's creation and modification dates, not the entries, same as the values displayed in the preview panel...

But this is still useful! I would refer to this as "date added", which I'm surprised I didn't have alongside the others in the roadmap.

@Computerdores
Copy link
Collaborator Author

Computerdores commented Dec 31, 2024

Time to add an Item to the roadmap that is already done :)

PS: That's fixed and I also added translations now that #662 is merged

@Computerdores Computerdores changed the title feat: Sorting by "Date Created" feat: Sorting by "Date Added" Dec 31, 2024
Copy link
Member

@CyanVoxel CyanVoxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved when comments are addressed 👍

@CyanVoxel CyanVoxel removed the Status: Review Needed A review of this is needed label Jan 10, 2025
@Computerdores
Copy link
Collaborator Author

comments have been addressed.

@CyanVoxel CyanVoxel merged commit 3cd56a8 into TagStudioDev:main Jan 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High An important issue requiring attention TagStudio: Search The TagStudio search engine Type: Enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants