Skip to content

Conversation

VasigaranAndAngel
Copy link
Collaborator

Replaced self.settings.clear() with self.settings.remove("") in the update_libs_list() method. the original implementation was clearing all settings. this bug prevented the app from reopening the last library also. and surprisingly no one noticed or reported it. this change ensures only the intended group of settings is cleared without affecting other values.

Copy link
Collaborator

@Computerdores Computerdores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this bug prevented the app from reopening the last library also.

It didn't for me (when exiting regularly, it would on crash/kill).

All in all seems to work and looks good!

@CyanVoxel CyanVoxel added the Type: Bug Something isn't working as intended label Dec 2, 2024
@CyanVoxel
Copy link
Member

I didn't seem to encounter the bug on macOS, but I do seem to encounter it on Windows, and this seems to address it!
Thank you for the fix!

@CyanVoxel CyanVoxel merged commit 8ba23c5 into TagStudioDev:main Dec 2, 2024
5 checks passed
yedpodtrzitko pushed a commit to yedpodtrzitko/TagStudio that referenced this pull request Dec 4, 2024
DandyDev01 pushed a commit to DandyDev01/TagStudio that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Something isn't working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants