feat: Reimplement drag drop files on sql migration by seakrueger · Pull Request #528 · TagStudioDev/TagStudio

seakrueger · 2024-09-28T20:43:45Z

commit `4e4bf6b`

Reimplements Drag and drop files in and out of TagStudio #153
Maintains commit history and message
Tested working dragging video/audio files into VLC
Tested working dragging files into TagStudio
- Known edge-case where thumbnails aren't updated if all dragged-in files overwrite existing files

commit `2f9ae0d`

Updates dialog to match other similar dialog
Cleans up and simplifies a lot of the logic in drop_import
Tested working dragging files and folds into TagStudio

commit `803f430`

Extracts useful function for ProgressWidget to that class
Implements said function where useful across the UI
Tested drop_import, find_unlinked, delete_unlinked, fix_unlinked
- merge_entries and mirror_entries are untested as I don't have dupe_guru, but should work?

Commits and commits title/messages are formatted to maintain authorship and split features, don't squash on merge

seakrueger · 2024-11-10T04:50:52Z

Sorry for the delay, this guy kind of slipped away into several tightly related features.

Old Dialog:

New Dialog (matches delete_unlinked entries):

* Ability to drop local files in to TagStudio to add to library * Added renaming option to drop import * Improved readability and switched to pathLib * format * Apply suggestions from code review Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Revert Change * Update tagstudio/src/qt/modals/drop_import.py Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Added support for folders * formatting * Progress bars added * Added Ability to Drag out of window * f * format * Ability to drop local files in to TagStudio to add to library * Added renaming option to drop import * Improved readability and switched to pathLib * format * Apply suggestions from code review Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Revert Change * Update tagstudio/src/qt/modals/drop_import.py Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Added support for folders * formatting * Progress bars added * Added Ability to Drag out of window * f * format * format * formatting and refactor * format again * formatting for mypy * convert lambda to func for clarity * mypy fixes * fixed dragout only worked on selected * Refactor typo, Add license * Reformat QMessageBox * Disable drops when no library is open Co-authored-by: Sean Krueger <skrueger2270@gmail.com> * Rebased onto SQL migration * Updated logic to based on selected grid_idx instead of selected ids * Add newly dragged-in files to SQL database * Fix buttons being inconsistant across platforms * Fix ruff formatting * Rename "override" button to "overwrite" --------- Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> Co-authored-by: Travis Abendshien <lvnvtravis@gmail.com> Co-authored-by: Sean Krueger <skrueger2270@gmail.com>

yedpodtrzitko

lgtm, but as usual - having some tests would be nice.

tagstudio/src/qt/modals/drop_import.py

yedpodtrzitko · 2024-11-10T11:57:22Z

tagstudio/src/qt/modals/drop_import.py

+            item.setEditable(False)
+            self.model.appendRow(item)
+
+        self.show()


When an action is required, I'd expect the window will gain focus. So I'd add self.driver.main_window.raise_() here. Otherwise the result might look like this, so I might not be even aware the drag&drop action havent finished:

Added, but window already raised on my system so unsure if that is fixed for you

tagstudio/src/qt/modals/drop_import.py

tagstudio/src/qt/modals/fix_unlinked.py

tagstudio/src/qt/widgets/progress.py

* Handle Qt events for main window in ts_qt.py * Replace magic values with enums * Match import duplicate file dialog to delete missing entry dialog * Remove excessive progess widgets * Add docstrings and logging

Extracts the create_progress_bar function from drop_import to the ProgressWidget class. Instead of creating a ProgressWidget, FunctionIterator, and CustomRunnable every time a thread-safe progress widget is needed, the from_iterable function in ProgressWidget now handles all of that.

seakrueger · 2024-11-13T20:50:24Z

Updated with feedback, still no tests as getting a lot of weird errors trying to work with files and copying in pytest

CyanVoxel

Thank you so much for your work on this! Tests would probably be nice in the long term, but I'm comfortable pulling this as-is for parity's sake.

…ev#528) * feat: Drag and drop files in and out of TagStudio (TagStudioDev#153) * Ability to drop local files in to TagStudio to add to library * Added renaming option to drop import * Improved readability and switched to pathLib * format * Apply suggestions from code review Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Revert Change * Update tagstudio/src/qt/modals/drop_import.py Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Added support for folders * formatting * Progress bars added * Added Ability to Drag out of window * f * format * Ability to drop local files in to TagStudio to add to library * Added renaming option to drop import * Improved readability and switched to pathLib * format * Apply suggestions from code review Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Revert Change * Update tagstudio/src/qt/modals/drop_import.py Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Added support for folders * formatting * Progress bars added * Added Ability to Drag out of window * f * format * format * formatting and refactor * format again * formatting for mypy * convert lambda to func for clarity * mypy fixes * fixed dragout only worked on selected * Refactor typo, Add license * Reformat QMessageBox * Disable drops when no library is open Co-authored-by: Sean Krueger <skrueger2270@gmail.com> * Rebased onto SQL migration * Updated logic to based on selected grid_idx instead of selected ids * Add newly dragged-in files to SQL database * Fix buttons being inconsistant across platforms * Fix ruff formatting * Rename "override" button to "overwrite" --------- Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> Co-authored-by: Travis Abendshien <lvnvtravis@gmail.com> Co-authored-by: Sean Krueger <skrueger2270@gmail.com> * refactor: Update dialog and simplify drop import logic * Handle Qt events for main window in ts_qt.py * Replace magic values with enums * Match import duplicate file dialog to delete missing entry dialog * Remove excessive progess widgets * Add docstrings and logging * refactor: add function for common ProgressWidget use Extracts the create_progress_bar function from drop_import to the ProgressWidget class. Instead of creating a ProgressWidget, FunctionIterator, and CustomRunnable every time a thread-safe progress widget is needed, the from_iterable function in ProgressWidget now handles all of that. --------- Co-authored-by: Creepler13 <denis.schlichting03@gmail.com> Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> Co-authored-by: Travis Abendshien <lvnvtravis@gmail.com>

seakrueger marked this pull request as draft September 28, 2024 20:48

CyanVoxel added this to the SQL Parity milestone Oct 1, 2024

CyanVoxel added Type: Enhancement New feature or request Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience labels Oct 1, 2024

seakrueger force-pushed the reimplement-drag-drop branch 3 times, most recently from 18d57c5 to 0ddd9c7 Compare October 7, 2024 21:25

seakrueger force-pushed the reimplement-drag-drop branch 5 times, most recently from df66b2e to 34376ec Compare November 3, 2024 02:19

seakrueger force-pushed the reimplement-drag-drop branch from 6773328 to d55186f Compare November 10, 2024 04:56

seakrueger force-pushed the reimplement-drag-drop branch from d55186f to 5d36abc Compare November 10, 2024 04:56

seakrueger marked this pull request as ready for review November 10, 2024 04:58

yedpodtrzitko reviewed Nov 10, 2024

View reviewed changes

seakrueger added 2 commits November 10, 2024 16:17

refactor: Update dialog and simplify drop import logic

2f9ae0d

* Handle Qt events for main window in ts_qt.py * Replace magic values with enums * Match import duplicate file dialog to delete missing entry dialog * Remove excessive progess widgets * Add docstrings and logging

seakrueger force-pushed the reimplement-drag-drop branch from 5d36abc to 803f430 Compare November 13, 2024 20:45

CyanVoxel added the Status: Review Needed A review of this is needed label Nov 14, 2024

CyanVoxel added the Priority: High An important issue requiring attention label Nov 29, 2024

CyanVoxel removed the Status: Review Needed A review of this is needed label Dec 7, 2024

CyanVoxel approved these changes Dec 11, 2024

View reviewed changes

CyanVoxel merged commit 385aaf4 into TagStudioDev:main Dec 12, 2024

CyanVoxel mentioned this pull request Dec 21, 2024

[Bug]: "Fix Unlinked Entries" not functioning, only returns None count #652

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Reimplement drag drop files on sql migration#528

feat: Reimplement drag drop files on sql migration#528
CyanVoxel merged 3 commits intoTagStudioDev:mainfrom
seakrueger:reimplement-drag-drop

seakrueger commented Sep 28, 2024 •

edited

Loading

Uh oh!

seakrueger commented Nov 10, 2024

Uh oh!

yedpodtrzitko left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yedpodtrzitko Nov 10, 2024

Uh oh!

seakrueger Nov 13, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

seakrueger commented Nov 13, 2024

Uh oh!

CyanVoxel left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

seakrueger commented Sep 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

commit 4e4bf6b

commit 2f9ae0d

commit 803f430

Uh oh!

seakrueger commented Nov 10, 2024

Uh oh!

yedpodtrzitko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yedpodtrzitko Nov 10, 2024

Choose a reason for hiding this comment

Uh oh!

seakrueger Nov 13, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

seakrueger commented Nov 13, 2024

Uh oh!

CyanVoxel left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

seakrueger commented Sep 28, 2024 •

edited

Loading

commit `4e4bf6b`

commit `2f9ae0d`

commit `803f430`