Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations #447

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

Tyrannicodin
Copy link
Contributor

Adds a translator that handles translation of objects via QCoreApplication.translate(context, key), and translations are stored as .ini files in the format:
*context*.*key*="*Translation*"

Currently has very few actually translated components, just the structure to add more.

@CyanVoxel CyanVoxel added Type: Enhancement New feature or request Type: Translation Translates or improves translation capabilities labels Sep 4, 2024
@CyanVoxel
Copy link
Member

Now that #332 has merged, this would be a great time to start separating out the strings to try using with Weblate

@CyanVoxel CyanVoxel added this to the Alpha v9.5 (Post-SQL) milestone Sep 10, 2024
@Bamowen
Copy link
Contributor

Bamowen commented Sep 17, 2024

Strings separated in #507
I guess the best course of action would either be to:

Any thoughts?

@Tyrannicodin how much is left for this to be a proper PR and not a draft?

@Tyrannicodin
Copy link
Contributor Author

@Tyrannicodin how much is left for this to be a proper PR and not a draft?

The only missing thing is replacing all strings with translation functions, which I want to do in this pr or else it won't really add much.

@Bamowen
Copy link
Contributor

Bamowen commented Sep 17, 2024

en.json
Here you go!

@Tyrannicodin
Copy link
Contributor Author

Hmm, I'm not sure we need to translate logs right? They're not user-facing after all.

@Bamowen
Copy link
Contributor

Bamowen commented Sep 18, 2024

Definitely lower priority, but I'm in favor of translating everything.

Completely fine with just removing them as you see fit. I do not have enough knowledge of the code base (or code in general for that matter) to decide for myself what is user facing and what's not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request Type: Translation Translates or improves translation capabilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants