Add Tag Modal: Keyboard nav improvements

[Computerdores]

Closes #405.

[eivl]

Fantastic change, this introduces the add tag modal with the expected behaviour.

[Computerdores]

I made no functional changes, only rebased onto main

[CyanVoxel]

I would love to pull this, but unfortunately there was some non-final UI changes to aliases that were attached to #596. If the alias UI gets reverted before #534 is finalized then I'd really like to pull this on top of the old UI.

[Computerdores]

As far as I am concerned I could also adapt this to the new UI once that is on main, up to you

[CyanVoxel]

As far as I am concerned I could also adapt this to the new UI once that is on main, up to you

If #534 develops and gets merged then that would be fantastic! If not or if the old UI is restored in the meantime, then I'll likely pull this as-is

[Computerdores]

I am reworking the keyboard navigation rn and would like some input regarding how the Tab Focus should move through the window. Main question is how to handle the lists of Aliases and Parent Tags.

The first idea has the advantage of being "what you see is what you get", while the second one has the advantage of always requiring the same number of tabs to go to Alias Add, Subtag Add, Color, Cancel and Save:

I personally lean towards the second idea as it would make the save and cancel buttons more easily reachable, but the first idea with shortcuts for color, save, cancel and the add buttons (save and cancel at the very least) would also be an option imo.

Idea 1

Idea 2

What's your take on this?

PS: For now I am changing it to Idea 1 because the current state is worse than both

[CyanVoxel]

I am reworking the keyboard navigation rn and would like some input regarding how the Tab Focus should move through the window. Main question is how to handle the lists of Aliases and Parent Tags.

The first idea has the advantage of being "what you see is what you get", while the second one has the advantage of always requiring the same number of tabs to go to Alias Add, Subtag Add, Color, Cancel and Save:

I personally lean towards the second idea as it would make the save and cancel buttons more easily reachable, but the first idea with shortcuts for color, save, cancel and the add buttons (save and cancel at the very least) would also be an option imo.

I think I prefer the second idea as well, and it would pair nicely with the arrow keys being used to navigate back up into the pre-existing alias list so it stays accessible.

I also know there's been some confusion around this, but the alias UI currently in the program is not permanent and was never supposed to be added - the "final" alias UI is due to be added in #534, however that shouldn't change the general idea of the navigation here, just the implementation specifics.

[CyanVoxel]

Removing the "blocked" status now that #534 has been merged

[CyanVoxel]

Thank you so much for your work on this!