🏷️ Add strict typing dicts for ts_library.json #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chao-master
force-pushed
the
feature/typed-dict-and-typing
branch
from
09e65f1 to
f0148c7
Compare
CyanVoxel
approved these changes
Apr 27, 2024
There was a problem hiding this comment.
Looks good! I'll go ahead and pull this, but in the future make sure to use PascalCase/CapWords for Python class names, as described the the PEP 8 Style Guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wip:
Adds a new file
json_typing.pythat includesTypedDictdeclarations for the json file formatThen uses those thoughout core where nessesary.
The main benefit is strict typing checking then making and reading the json
Unfinished work:
fields, I couldn't work out that is being stored or loaded heremacros, I can't actually tell if these are used