Replace use of os.path with pathlib #156

Icosahunter · 2024-05-10T01:22:35Z

No description provided.

Icosahunter · 2024-05-10T01:23:29Z

Tested on Linux (Solus) for basic functionality

tagstudio/src/cli/ts_cli.py

tagstudio/src/core/library.py

tagstudio/src/cli/ts_cli.py

tagstudio/src/core/library.py

yedpodtrzitko · 2024-05-10T02:31:03Z

good job, this was really needed 👍

Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com>

Icosahunter · 2024-05-10T04:07:37Z

@yedpodtrzitko Thanks for the comments, I think I've resolved most of them. I'll have to test with the changes and ruff-format it again.

yedpodtrzitko · 2024-05-19T11:39:53Z

tagstudio/src/qt/widgets/thumb_renderer.py

            qim = ImageQt.ImageQt(final)
+            final.save(f'/home/icosahunter/Documents/test/{filepath.stem}.png')


whoops, I'll need to fix that 🤦‍♂️

Icosahunter · 2024-05-23T01:11:10Z

Tested basic functionality on my Linux distro (Solus) and seems to be working. At one point I did get a segfault... but it didn't happen in later testing.

tagstudio/src/core/library.py

tagstudio/src/qt/widgets/preview_panel.py

tagstudio/src/qt/widgets/thumb_renderer.py

Co-authored-by: Travis Abendshien <46939827+CyanVoxel@users.noreply.github.com>

Icosahunter · 2024-05-26T21:27:26Z

Got a segmentation fault when trying to delete unlinked entries, but I couldn't reproduce the issue.

[ThumbRenderer][ERROR]: Couldn't render thumbnail for /home/icosahunter/Documents/test.txt ([Errno 2] No such file or directory: '/home/icosahunter/Documents/test.txt')
Traceback (most recent call last):
  File "/home/icosahunter/Repos/TagStudio/tagstudio/src/qt/widgets/preview_panel.py", line 530, in update_widgets
    raise UnidentifiedImageError
PIL.UnidentifiedImageError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/icosahunter/Repos/TagStudio/tagstudio/src/qt/ts_qt.py", line 1209, in <lambda>
    lambda checked=False, entry=entry: self.select_item(
                                       ^^^^^^^^^^^^^^^^^
  File "/home/icosahunter/Repos/TagStudio/tagstudio/src/qt/ts_qt.py", line 1137, in select_item
    self.preview_panel.update_widgets()
  File "/home/icosahunter/Repos/TagStudio/tagstudio/src/qt/widgets/preview_panel.py", line 539, in update_widgets
    f"{filepath.suffix.upper()[1:]}  •  {format_size(os.stat(filepath).st_size)}"
                                                     ^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/home/icosahunter/Documents/test.txt'
Start RMF: <PySide6.QtCore.QThread(0x55681a5ac5b0) at 0x7fc9d3f2d600>
TagStudio.sh: line 7:  9544 Segmentation fault      (core dumped) python tagstudio/tag_studio.py

- Suffix comparisons are now case-insensitive - Restore original thumbnail extension label behavior - Fix preview panel trying to read file size from missing files

Icosahunter added 10 commits April 28, 2024 13:28

Replace usage of os.path with usage of pathlib.Path in ts_cli.py

3db106a

Replace use of os.path with pathlib in Library.py

6b2fec0

Replace use of os.path with pathlib in ts_core.py

55bc40e

resolve entry path/filename on creation/update

e307c0c

Fix errors and bugs related to move from os.path to pathlib.

7bc5158

Remove most uses of '.resolve()' as it didn't do what I thought it did

cf959df

Fix filtering in refresh directories to not need to cast to string.

6dd7309

Some work on ts_qt, thumbnails don't load...

b33beeb

Fixed the thumbnail issue, things seem to be working.

7834b98

Fix some bugs

f6fa868

CyanVoxel added the Type: Refactor Code that needs to be restructured or cleaned up label May 10, 2024

CyanVoxel added this to the Alpha 9.3.x milestone May 10, 2024

Merge branch 'main' into main

6406940

yedpodtrzitko reviewed May 10, 2024

View reviewed changes

tagstudio/src/cli/ts_cli.py Outdated Show resolved Hide resolved

yedpodtrzitko reviewed May 10, 2024

View reviewed changes

tagstudio/src/core/library.py Outdated Show resolved Hide resolved