fix: use first file as epub thumbnail instead of the last. #1111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Computerdores
approved these changes
Sep 7, 2025
Collaborator
Computerdores
left a comment
Computerdores
left a comment
There was a problem hiding this comment.
Was about to mention this when @CyanVoxel merged the prior PR ^^
CyanVoxel
added
Type: UI/UX
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If an ePub contains no ComicInfo.xml the first image should be used as the fallback thumbnail.
Currently, the last image will be used due to a missing
breakafter the first image is loaded.Fixes #1051 (at least for zip based ePubs)
Before
After
Files used for testing
Again renamed because of GitHub upload limitiations.
Tasks Completed