fix: prevent mnemonic removal from removing escaped ampersands #1110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Type: UI/UX
| if ch == "&": | ||
| # escaped ampersand "&&" | ||
| if i + 1 < len(label) and label[i + 1] == "&": | ||
| result += "&" |
Collaborator
There was a problem hiding this comment.
Can you try changing this to result += "&&"? I think that should fix it too and would technically be more robust
Member
Author
There was a problem hiding this comment.
That also seems to fix it - It was just difficult to parse the logic and see what was going wrong where. I can go ahead and make this change though, I'm not the biggest fan of using a placeholder like in the original logic, even if it did simplify it to an easier to follow one-liner
CyanVoxel
changed the title
Computerdores
approved these changes
Sep 7, 2025
github-project-automation
bot
moved this from 🍃 Pending Merge
to ✅ Done
in TagStudio Development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1100 by preventing the mnemonic removal logic from removing escaped ampersands.
Tasks Completed