fix: don't flush entire changes when adding tags in bulk #1081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Type: Bug
Computerdores
approved these changes
Sep 1, 2025
Collaborator
Computerdores
left a comment
Computerdores
left a comment
There was a problem hiding this comment.
didn't test extensively but the issue is indeed fixed on win10 for me and code looks good
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in TagStudio Development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #1080 by attempting to commit the added tag at each step in
def add_tags_to_entries()rather than flushing, so that a rollback doesn't wipe all the previously verified yet uncommitted issues