fix: use srctools instead of vtf2img to render vtf files #1014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Type: Bug
Contributor
|
Testing this PR on windows (x64), build from source with pyinstaller. 
Seems to be working as expected on my end. As far as i know VMT is outside the scope of the PR, so them not displaying is expected (and considering that they are materials, i don't think there is a good way to do it easily.) |
github-project-automation
bot
moved this from 🏓 Ready for Review
to ✅ Done
in TagStudio Development
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the vtf2img library dependency with srctools in order to render VTF files.
Example VTF files used: https://github.com/TeamSpen210/srctools/tree/master/tests/test_vtf
Fixes #980.
vtf2img:
srctools:
Tasks Completed