Skip to content

[Bug]: Access keys (mnemonics) breaking guidelines #678

Open
@smileyhead

Description

@smileyhead

Checklist

  • I am using an up-to-date version.
  • I have read the documentation.
  • I have searched existing issues.

TagStudio Version

Alpha 9.4.2

Operating System & Version

Windows 11 Pro 22631.4602

Description

Some of the access keys used in menus break Microsoft's guidelines. I believe respecting those guidelines would be better for accessibility.

Expected Behavior

My observations and suggestions are as follows:

File menu

Current State Comment Suggestion
Open/Create Library
Save Library
Save Library Backup Conflict with Save Library.* Save Library Backup
Refresh Dictionaries
Close Library

* I would suggest Backup instead, but it's better to pick and earlier word for discoverability. (Perhaps it might be worth shortening this to Save Backup?)

Edit menu

Current State Comment Suggestion
New Tag ‘New’ should be prioritised here. New Tag
Copy Fields
Paste Fields
Select All Missing access key.* Select All
Clear Selection Missing access key. Clear Selection
Delete Selected File(s) Missing access key. Delete Selected File(s)
Manage File Extensions Missing access key. Manage File Extensions
Manage Tags Missing access key. Manage Tags

* ‘All’ is prioritised here by convention.

Tools menu

Current State Comment Suggestion
Fix Unlinked Entries
Fix Duplicate Files ‘Duplicate‘ should be prioritised here. Fix Duplicate Files
Create Collage Missing access key. Create Collage

Macros menu

Current State Comment Suggestion
Autofill Missing access key. Autofill
Sort Fields
Folders to Tags Missing access key. Folders to Tags

Window menu

Current State Comment Suggestion
Open Library On Start Missing access key. Open Library On Start
Show Recent Libraries Missing access key. Show Recent Libraries

Help menu

Current State Comment Suggestion
Visit GitHub Repository Missing access key. Visit GitHub Repository

Add Tag window (Ctrl + T)

Current State Comment Suggestion
Name Missing access key. Name
Shorthand Missing access key. Shorthand
Aliases Missing access key. Aliases
+ Missing access key. Should be changed for accessibility. Add
- Missing access key. Should be changed for accessibility. Remove
Color Missing access key. Color

File Extensions window

Current State Comment Suggestion
List Mode Missing access key. List Mode
Add Extension
Cancel Missing access key.* Cancel
Save Missing access key. Save

* Esc should be the access key here (unlabelled).
Additionally, the commit buttons should be presented in the following order: Save, Cancel.

Library Tags window

Current State Comment Suggestion
Search Tags Missing access key. Search Tags
Done Missing access key.* Done

* Esc should be the access key here (unlabelled).

Fix Unlinked Entries window

Current State Comment Suggestion
Refresh All ‘All’ should be prioritised here.* Refresh All
Search & Relink
Delete Unlinked Entries The access key can be moved.** Delete Unlinked Entries
Refresh Duplicate Entries Missing access key. Refresh Duplicate Entries
Merge Duplicate Entries
Done The access key can be moved.*** Done

* By convention (‘Select All’), and this also solves a conflict with Refresh Duplicate Entries.
** It is better to avoid thin letters for visibility, and D wasn't a conflicting letter, anyway.
*** Esc should be the access key here (unlabelled).

Fix Duplicate Files window

Current State Comment Suggestion
Load DupeGuru File
Mirror Entries
Done The access key can be moved.* Done

* Esc should be the access key here (unlabelled).

Create Tags From Folders window

Current State Comment Suggestion
Open All Missing access key. Open All
Close All Missing access key. Close All
Apply

Additionally, a Cancel button (accessed with Esc) would be nice here.


In addition to all this, the main window of the program could use some access keys as well:

Current State Comment Suggestion
< Missing access key.* <
> Missing access key.* >
Search Entries Missing access key. Search Entries
[Search Mode drop-down] Missing label and access key. Search Mode:
[Thumbnail Size drop-down] Missing label and access key. View:

* The Back and Forward actions are conventionally accessed with Alt + and Alt +

Steps to Reproduce

  1. Open TagStudio
  2. Check menus

Logs

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Priority: MediumAn issue that shouldn't be be saved for lastType: BugSomething isn't working as intendedType: UI/UXUser interface and/or user experience

    Type

    No type

    Projects

    Status

    🛠 Ready for Development

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions