fix: allow dragging slider after click

Author: csponge

src/tagstudio/qt/helpers/qslider_wrapper.py

@@ -12,8 +12,6 @@ class QClickSlider(QSlider):
     based on click events.
     """
 
-    mouse_pressed = False
-
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
 
@@ -32,25 +30,12 @@ def mousePressEvent(self, event):  # noqa: N802
 
         was_slider_clicked = handle_rect.contains(event.position().x(), event.position().y())
 
-        if was_slider_clicked:
-            super().mousePressEvent(event)
-        else:
+        if not was_slider_clicked:
             self.setValue(
                 QStyle.sliderValueFromPosition(
                     self.minimum(), self.maximum(), event.x(), self.width()
                 )
             )
             self.mouse_pressed = True
 
-    def observe_mouse(self) -> bool:
-        """Getter for the mouse_pressed property.
-
-        This will also clear the mouse_pressed property
-        if it is set. We do this so that consumers of slider
-        events can modify the sliders position.
-        """
-        if self.mouse_pressed:
-            self.mouse_pressed = False
-            return True
-
-        return False
+        super().mousePressEvent(event)

src/tagstudio/qt/widgets/media_player.py

@@ -453,9 +453,7 @@ def slider_released(self) -> None:
             self.player.pause()
 
     def player_position_changed(self, position: int) -> None:
-        if self.pslider.observe_mouse():
-            self.player.setPosition(self.pslider.value())
-        elif not self.pslider.isSliderDown():
+        if not self.pslider.isSliderDown():
             # User isn't using the slider, so update position in widgets.
             self.pslider.setValue(position)
             current = self.format_time(self.player.position())