Skip to content

Commit 2a836b0

Browse files
docs: discourage force-pushes on prs that are open for review (#714)
* Update CONTRIBUTING.md * Update CONTRIBUTING.md
1 parent 6ea2c99 commit 2a836b0

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

CONTRIBUTING.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,11 @@ Most of the style guidelines can be checked, fixed, and enforced via Ruff. Older
157157
- Pull requests should have an adequate title and description which clearly outline your intentions and changes/additions. Feel free to provide screenshots, GIFs, or videos, especially for UI changes.
158158
- Pull requests should ideally be limited to **a single** feature or fix.
159159

160+
> [!IMPORTANT]
161+
> Please do not force push if your PR is open for review!
162+
>
163+
> Force pushing makes it impossible to discern which changes have already been reviewed and which haven't. This means a reviewer will then have to rereview all the already reviewed code, which is a lot of unnecessary work for reviewers.
164+
160165
> [!TIP]
161166
> If you're unsure where to stop the scope of your PR, ask yourself: _"If I broke this up, could any parts of it still be used by the project in the meantime?"_
162167

0 commit comments

Comments
 (0)