fix(vscode): Preserve editor selection on webview focus #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the selection handling logic in `TabState` to correctly preserve the last active editor selection when focus is moved to a Pochi webview panel. - `onTabChanged` and `onSelectionChanged` now only update the active selection if a new valid selection is found. - `onTabChanged` also clears the selection if the corresponding file tab is closed. This approach makes the previous changes to `preserveFocus` in `PochiWebviewPanel` redundant, so those changes have been reverted. 🤖 Generated with [Pochi](https://getpochi.com) Co-Authored-By: Pochi <noreply@getpochi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses an issue where the active editor selection was lost when focus shifted to a Pochi webview panel.
The key changes include:
TabStateto conditionally update the active selection, preserving it when focus moves to a webview.preserveFocuschanges inPochiWebviewPanel.Test plan
🤖 Generated with Pochi