[BUGFIX] Allow quoting in TypoScript's select for leftjoin & rightjoin

georgringer · bmack · commit f9fb71b9940e · 2021-02-10T10:36:07.000+01:00
By fixing a typo, the field quoting also works for `leftjoin` and `rightjoin`. Resolves: #93449 Releases: master, 10.4, 9.5 Change-Id: I65c08d17f7f41a505fc4e23fbafd775469e9a13a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67695 Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Benni Mack <benni@typo3.org> Reviewed-by: Benni Mack <benni@typo3.org>
diff --git a/Classes/ContentObject/ContentObjectRenderer.php b/Classes/ContentObject/ContentObjectRenderer.php
@@ -6604,7 +6604,7 @@ public function getQuery($table, $conf, $returnQueryArray = false)
             );
             if ($conf[$property] === '') {
                 unset($conf[$property]);
-            } elseif (in_array($property, ['languageField', 'selectFields', 'join', 'leftJoin', 'rightJoin', 'where'], true)) {
+            } elseif (in_array($property, ['languageField', 'selectFields', 'join', 'leftjoin', 'rightjoin', 'where'], true)) {
                 $conf[$property] = QueryHelper::quoteDatabaseIdentifiers($connection, $conf[$property]);
             }
             if (isset($conf[$property . '.'])) {

Original file line number	Diff line number	Diff line change
`@@ -6604,7 +6604,7 @@ public function getQuery($table, $conf, $returnQueryArray = false)`
`6604`	`6604`	`);`
`6605`	`6605`	`if ($conf[$property] === '') {`
`6606`	`6606`	`unset($conf[$property]);`
`6607`		`- } elseif (in_array($property, ['languageField', 'selectFields', 'join', 'leftJoin', 'rightJoin', 'where'], true)) {`
	`6607`	`+ } elseif (in_array($property, ['languageField', 'selectFields', 'join', 'leftjoin', 'rightjoin', 'where'], true)) {`
`6608`	`6608`	`$conf[$property] = QueryHelper::quoteDatabaseIdentifiers($connection, $conf[$property]);`
`6609`	`6609`	`}`
`6610`	`6610`	`if (isset($conf[$property . '.'])) {`