-
Notifications
You must be signed in to change notification settings - Fork 18
Develop #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
spmulders
merged 23 commits into
TUDelft-DataDrivenControl:master
from
nikhar-abbas:develop
Nov 5, 2019
Merged
Develop #7
spmulders
merged 23 commits into
TUDelft-DataDrivenControl:master
from
nikhar-abbas:develop
Nov 5, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Definitely want to check the CMakeLists.txt file for comprehensiveness. Especially to work with gfortran compilers, as I haven't been able to check for those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few big changes here:
Compile process changed to cmake. This makes things simpler for Unix machines, and it is inline with the direction that openfast is going for compiling. May want to distribute a vs solution as well. Also, there may be some bugs for compiling using gfortran.
Significant changing to nomenclature, readme, etc. Changed name to ROSCO and added a compile description, etc. Tried to update acknowledgements and referencing information fairly as well, but is certainly subject to change