Using Hierarchical Tags in 1.2.0 is broken when generating html report

[jadhindieh]

I tried creating Hierarchical tags in jgiven 1.2.0 and the html report never opens. using a single tag in the 1.2.0 we do get an html report.

To reproduce:

• create a parent tag
• create a child tag and annotate it with parent
• add the child annotation to the test case
• generate the html report
• check the results

I have tested this scenario on 0.17.1 and I was able to get an html report, but when I upgrade to 1.2.0, I lose the html report.
please find attached the screenshots of scenario and results:

• jgiven version:

• tags:

• html tags results:

• jgiven version:

• no change to code

• html tags results:

[l-1squared]

Hi,
thanks for informing me about the issue. I will attempt to solve the issue as soon as possible (probably monday)

[l-1squared]

Managed to reproduce the bug. Feature still seems to work with version 1.1.0

[l-1squared]

apparently the issue occurs with this commit: fd97825. It appears that the parent tags do not get written into the tagMap.js anymore.
Will continue investigation tomorrow

[l-1squared]

Identified the root cause. There was a side-effect in the tag creation process that seemed irrelevant but actually ensured that the report model knew the parent tags of a given tag.

[jadhindieh]

Thank you for the fast resolution

[jadhindieh]

I just restarted working on the project and used the version 1.2.1.
There is still an issue after the fix. If a new issue is required please let me know. I will provide the new issue details here for now:

The issue is as follows: if we have 3 layers ( Parent, child, child of child (grandchild) ) the report will be generated, however the tags will get messed up.
supposing I have a tag Parent, I create a new tag Child and annotate it with Parent. then I create a new Tag GChild and I annotate this one with Child. the expected behavior is that we get 3 nested tags: Parent -> Child -> GChild. The actual behavior is that the GChild is showing as a child of the Parent.
Please refer to the screenshots for the Expected (extracted from version 1.1.0) vs Actual ( V1.2.1)
V1.1.0:

V1.2.1:

[l-1squared]

@jadhindieh Thanks for reporting. I have an idea how that came to pass.

[l-1squared]

@jadhindieh I think I found the cause, but I want to take some more time to consolidate the code and maybe come up with another test or two.