Fixed bug with scuffed fix for multiple group password geneation

cianjinks · cianjinks · commit bdef36eac724 · 2020-05-24T23:49:52.000+01:00
diff --git a/src/main/java/ie/tcd/pavel/MongoDBOperations.java b/src/main/java/ie/tcd/pavel/MongoDBOperations.java
@@ -188,7 +188,9 @@ public void deleteExercise(String owner, String type, Date date)
     public void insertGroup(String name, String password, String user)
     {
         mongoTemplate.insert(new Group(name,user));
-        mongoTemplate.insert(new GroupPassword(name,encoder.encode(password)));
+        if(getUsersByGroup(name).size() < 2) {
+            mongoTemplate.insert(new GroupPassword(name,encoder.encode(password)));
+        }
     }
 
     public Group findGroup(String user, String group)

Original file line number	Diff line number	Diff line change
`@@ -188,7 +188,9 @@ public void deleteExercise(String owner, String type, Date date)`
`188`	`188`	`public void insertGroup(String name, String password, String user)`
`189`	`189`	`{`
`190`	`190`	`mongoTemplate.insert(new Group(name,user));`
`191`		`- mongoTemplate.insert(new GroupPassword(name,encoder.encode(password)));`
	`191`	`+ if(getUsersByGroup(name).size() < 2) {`
	`192`	`+ mongoTemplate.insert(new GroupPassword(name,encoder.encode(password)));`
	`193`	`+ }`
`192`	`194`	`}`
`193`	`195`
`194`	`196`	`public Group findGroup(String user, String group)`