New feature: iNES header editor #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
owomomo
commented
Jun 19, 2019
•
owomomo
commented
- New experimental feature: iNES header editor. As the name descripbes, it can edit the NES ROM header.
- Global cheat enable/disable cheat switch.
- Separated Game Genie and Cheat code to different edit control in Cheat console.
- Export cheat manually button.
- Don't show Game Genie code when cheat address is below 0x8000, since it cannot be done by normal Game Genie.
- Detail: Experimental limit input characters for some edit control such as address, numbers, etc. to prevent invalid character input.
- Other details.
Sync code to the newest
Sync code to the newest
1. Added a global switch for all cheats, it is checked by default. Check or uncheck it can quickly tweak all cheats enabled or disabled. It's not game specific and effective to all games. 2. Added a checkmark to check behaviour of automatically load cheats. 3. Fixed a wierd bug in loading names of cheats from file. iNES Header Editor: 4. Disable iNES header editor menu when currently loaded game is not in iNES format. Others: 5. Some of the checkbox passed parameter MF_CHECKED, the right one is BST_CHECKED, though they have the same value. 6. Code/Data Logger is created by CreateDialog(), but destroyed by EndDialog()? A non-modal window should be destroy by DestroyWindow(), EndDialog() is for DialogBox(). It seems nobody noticed this bug for years. Currently there are some opposite tweaks in the config file for the new feature in cheat console, for example the unchcecked state is 1 in config file, that's for backward compatibility. The iNES header editor might not quite stable as newly baked from the oven, there might be some improvements to its code.
1. Added a global switch for all cheats, it is checked by default. Check or uncheck it can quickly tweak all cheats enabled or disabled. It's not game specific and effective to all games. 2. Added a checkmark to check behaviour of automatically load cheats. 3. Fixed a wierd bug in loading names of cheats from file. iNES Header Editor: 4. Disable iNES header editor menu when currently loaded game is not in iNES format. Others: 5. Some of the checkbox passed parameter MF_CHECKED, the right one is BST_CHECKED, though they have the same value. 6. Code/Data Logger is created by CreateDialog(), but destroyed by EndDialog()? A non-modal window should be destroy by DestroyWindow(), EndDialog() is for DialogBox(). It seems nobody noticed this bug for years. 7. Detail. Currently there are some opposite tweaks in the config file for the new feature in cheat console, for example the unchcecked state is 1 in config file, that's for backward compatibility. The iNES header editor might not quite stable as newly baked from the oven, there might be some improvements to its code.
2. Removed HWND pwindow, since it's ambiguous and not too much used. The pallete window use it's own global HWND variable.
2. Separated cheat code and game genie in Cheat window. 3. Don't show a game genie code when affected address is under 0x8000. 4. Detail: set font for some edit control, replaced some static global variable. 5. Other details. By the way, why there're so many useless brackets in some functions?
2. Add text limit to Memory Watch for experiment. 3. Make the IDs of controls in Memory Watch predefined rather than directly coded, that's not quite standard in programming. Calculations to ID is not always trusted as they are automatically determined by the development tool.
2. Add text limit to Memory Watch for experiment. 3. Make the IDs of controls in Memory Watch predefined rather than directly coded, that's not quite standard in programming. Calculations to ID is not always trusted as they are automatically determined by the development tool.
2. Changed limit input behaviour to match the system default ES_NUMBER.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.