remove updateCooldown variable

Author: Morilli

src/BizHawk.Client.EmuHawk/RetroAchievements/RCheevos.cs

@@ -192,7 +192,7 @@ private void BuildMenu(ToolStripItemCollection raDropDownItems)
 			var viewCheevoListItem = new ToolStripMenuItem("View Achievement List");
 			viewCheevoListItem.Click += (_, _) =>
 			{
-				_cheevoListForm.OnFrameAdvance(HardcoreMode, true);
+				_cheevoListForm.OnFrameAdvance(HardcoreMode);
 				_cheevoListForm.Show();
 			};
 			raDropDownItems.Add(viewCheevoListItem);

src/BizHawk.Client.EmuHawk/RetroAchievements/RCheevosAchievementListForm.cs

@@ -3,7 +3,6 @@
 using System.Linq;
 using System.Windows.Forms;
 
-using BizHawk.Common;
 using BizHawk.Common.NumberExtensions;
 
 namespace BizHawk.Client.EmuHawk
@@ -15,7 +14,6 @@ public partial class RCheevosAchievementListForm : Form
 	{
 		private RCheevos.Cheevo[] _cheevos;
 		private RCheevosAchievementForm[] _cheevoForms;
-		private int _updateCooldown;
 		private Func<uint, string> _getCheevoProgress;
 		private Func<bool> _isHardcodeMode;
 
@@ -26,7 +24,6 @@ public RCheevosAchievementListForm()
 			InitializeComponent();
 			FormClosing += RCheevosAchievementListForm_FormClosing;
 			_cheevoForms = Array.Empty<RCheevosAchievementForm>();
-			_updateCooldown = 5; // only update every 5 frames / 12 fps (as this is rather expensive to update)
 			using var temp = new RCheevosAchievementForm(null);
 			_controlHeight = temp.Height + temp.Margin.Bottom + temp.Margin.Top;
 		}
@@ -57,22 +54,16 @@ public void Restart(IEnumerable<RCheevos.Cheevo> cheevos, Func<uint, string> get
 			UpdateForms();
 		}
 
-		public void OnFrameAdvance(bool hardcore, bool forceUpdate = false)
+		public void OnFrameAdvance(bool hardcore)
 		{
-			_updateCooldown--;
-			if (_updateCooldown == 0 || forceUpdate)
-			{
-				_updateCooldown = 5;
-
-				var reorderedCheevos = _cheevos.OrderByDescending(f => f.OrderByKey(_getCheevoProgress)).ToArray();
-				_cheevos = reorderedCheevos;
+			var reorderedCheevos = _cheevos.OrderByDescending(f => f.OrderByKey(_getCheevoProgress)).ToArray();
+			_cheevos = reorderedCheevos;
 
-				UpdateForms();
+			UpdateForms();
 
-				foreach (var form in _cheevoForms)
-				{
-					form.OnFrameAdvance(hardcore);
-				}
+			foreach (var form in _cheevoForms)
+			{
+				form.OnFrameAdvance(hardcore);
 			}
 		}