Skip to content

Commit 8486b56

Browse files
committed
Explicitly disable many Roslynator rules
1 parent 6381c93 commit 8486b56

File tree

2 files changed

+96
-6
lines changed

2 files changed

+96
-6
lines changed

.editorconfig

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,10 +127,6 @@ dotnet_diagnostic.IDE0260.severity = suggestion
127127
dotnet_diagnostic.IDE0280.severity = error
128128
# Collection initialization can be simplified
129129
dotnet_diagnostic.IDE0305.severity = silent
130-
# Add parentheses when necessary
131-
dotnet_diagnostic.RCS1123.severity = silent
132-
# Remove suffix 'Async' from non-asynchronous method name
133-
dotnet_diagnostic.RCS1047.severity = silent # see #2888
134130

135131
csharp_style_var_when_type_is_apparent = true
136132
csharp_style_var_elsewhere = true

.global.editorconfig.ini

Lines changed: 96 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ dotnet_diagnostic.MA0027.severity = error
213213
# Optimize StringBuilder usage
214214
dotnet_diagnostic.MA0028.severity = silent
215215
# Combine LINQ methods
216-
dotnet_diagnostic.MA0029.severity = error
216+
dotnet_diagnostic.MA0029.severity = error # redundant with IDE0120
217217
# Remove useless OrderBy call
218218
dotnet_diagnostic.MA0030.severity = error
219219
# Optimize Enumerable.Count() usage
@@ -239,7 +239,7 @@ dotnet_diagnostic.MA0041.severity = silent
239239
# Do not use blocking calls in an async method
240240
dotnet_diagnostic.MA0042.severity = silent # DoNotUseBlockingCallInAsyncContextAnalyzer very slow
241241
# Use nameof operator in ArgumentException
242-
dotnet_diagnostic.MA0043.severity = error
242+
dotnet_diagnostic.MA0043.severity = silent # redundant with CA1507
243243
# Remove useless ToString call
244244
dotnet_diagnostic.MA0044.severity = warning
245245
# Do not use blocking call in a sync method (need to make containing method async)
@@ -430,42 +430,126 @@ dotnet_diagnostic.MEN018.severity = warning
430430

431431
## Roslynator.Analyzers rules
432432

433+
# Use nameof operator
434+
dotnet_diagnostic.RCS1015.severity = silent # redundant with CA1507
435+
# Remove redundant boolean literal
436+
dotnet_diagnostic.RCS1033.severity = silent # redundant with IDE0100
437+
# Remove trailing white-space
438+
dotnet_diagnostic.RCS1037.severity = silent # redundant with SA1028
433439
# Remove 'partial' modifier from type with a single part
434440
dotnet_diagnostic.RCS1043.severity = warning
441+
# Remove original exception from throw statement
442+
dotnet_diagnostic.RCS1044.severity = silent # redundant with MA0027
443+
# Non-asynchronous method name should not end with 'Async'
444+
dotnet_diagnostic.RCS1047.severity = silent # pending https://github.com/TASEmulators/BizHawk/issues/2888
445+
# Use lambda expression instead of anonymous method
446+
dotnet_diagnostic.RCS1048.severity = silent # redundant with BHI1001
447+
# Simplify boolean comparison
448+
dotnet_diagnostic.RCS1049.severity = silent # redundant with IDE0100
449+
# Use compound assignment
450+
dotnet_diagnostic.RCS1058.severity = silent # redundant with IDE0054
435451
# Avoid locking on publicly accessible instance
436452
dotnet_diagnostic.RCS1059.severity = silent
437453
# Avoid empty catch clause that catches System.Exception
438454
dotnet_diagnostic.RCS1075.severity = silent
455+
# Optimize LINQ method call
456+
dotnet_diagnostic.RCS1077.severity = silent # redundant with IDE0120
439457
# Use 'Count/Length' property instead of 'Any' method
440458
dotnet_diagnostic.RCS1080.severity = error
459+
# Use --/++ operator instead of assignment
460+
dotnet_diagnostic.RCS1089.severity = silent # redundant with IDE0054
461+
# File contains no code
462+
dotnet_diagnostic.RCS1093.severity = silent
463+
# Remove redundant 'ToString' call
464+
dotnet_diagnostic.RCS1097.severity = silent # redundant with MA0044
465+
# Constant values should be placed on right side of comparisons
466+
dotnet_diagnostic.RCS1098.severity = silent # comes for free w/ pattern matching
467+
# Default label should be the last label in a switch section
468+
dotnet_diagnostic.RCS1099.severity = silent
441469
# Make class static
442470
dotnet_diagnostic.RCS1102.severity = silent
471+
# Simplify conditional expression
472+
dotnet_diagnostic.RCS1104.severity = silent # redundant with IDE0075
473+
# Declare type inside namespace
474+
dotnet_diagnostic.RCS1110.severity = silent # redundant with MA0047
475+
# Combine 'Enumerable.Where' method chain
476+
dotnet_diagnostic.RCS1112.severity = silent # redundant with MA0029
477+
# Add parentheses when necessary
478+
dotnet_diagnostic.RCS1123.severity = silent
479+
# Use coalesce expression
480+
dotnet_diagnostic.RCS1128.severity = silent # redundant with IDE0074
443481
# Bitwise operation on enum without Flags attribute
444482
dotnet_diagnostic.RCS1130.severity = error
483+
# Declare enum member with zero value (when enum has FlagsAttribute)
484+
dotnet_diagnostic.RCS1135.severity = silent # redundant with CA1008
445485
# Add summary to documentation comment
446486
dotnet_diagnostic.RCS1138.severity = silent
447487
# Add summary element to documentation comment
448488
dotnet_diagnostic.RCS1139.severity = silent
489+
# Use StringComparison when comparing strings
490+
dotnet_diagnostic.RCS1155.severity = silent # redundant with CA1862
449491
# Use string.Length instead of comparison with empty string
450492
dotnet_diagnostic.RCS1156.severity = error
451493
# Composite enum value contains undefined flag
452494
dotnet_diagnostic.RCS1157.severity = warning
495+
# Static member in generic type should use a type parameter
496+
dotnet_diagnostic.RCS1158.severity = silent # redundant with CA1000/MA0018
497+
# Use EventHandler<T>
498+
dotnet_diagnostic.RCS1159.severity = silent
453499
# Abstract type should not have public constructors
454500
dotnet_diagnostic.RCS1160.severity = error
501+
# Unused parameter
502+
dotnet_diagnostic.RCS1163.severity = silent # redundant with IDE0060
503+
# Value type object is never equal to null
504+
dotnet_diagnostic.RCS1166.severity = silent # redundant with CS0472
505+
# Make field read-only
506+
dotnet_diagnostic.RCS1169.severity = silent # redundant with IDE0044
507+
# Use read-only auto-implemented property
508+
dotnet_diagnostic.RCS1170.severity = silent # redundant with MEN017
509+
# Simplify lazy initialization
510+
dotnet_diagnostic.RCS1171.severity = silent # redundant with IDE0074
511+
# Unused 'this' parameter
512+
dotnet_diagnostic.RCS1175.severity = silent # redundant with IDE0060
513+
# Inline lazy initialization
514+
dotnet_diagnostic.RCS1180.severity = silent # redundant with IDE0074
515+
# Use constant instead of field
516+
dotnet_diagnostic.RCS1187.severity = silent
455517
# Declare enum value as combination of names
456518
dotnet_diagnostic.RCS1191.severity = warning
519+
# Overriding member should not change 'params' modifier
520+
dotnet_diagnostic.RCS1193.severity = silent # redundant with MA0081
457521
# Implement exception constructors
458522
dotnet_diagnostic.RCS1194.severity = silent
459523
# Use ^ operator
460524
dotnet_diagnostic.RCS1195.severity = warning
525+
# Use AttributeUsageAttribute
526+
dotnet_diagnostic.RCS1203.severity = silent # redundant with MA0010
527+
# Use EventArgs.Empty
528+
dotnet_diagnostic.RCS1204.severity = silent # redundant with MA0019
529+
# Order named arguments according to the order of parameters
530+
dotnet_diagnostic.RCS1205.severity = silent
531+
# Return completed task instead of returning null
532+
dotnet_diagnostic.RCS1210.severity = silent # redundant with MA0022
533+
# Remove unused member declaration
534+
dotnet_diagnostic.RCS1213.severity = silent # redundant with CS0414
535+
# Use pattern matching instead of combination of 'as' operator and null check
536+
dotnet_diagnostic.RCS1221.severity = silent # redundant with IDE0019
537+
# Merge preprocessor directives
538+
dotnet_diagnostic.RCS1222.severity = silent
461539
# Make method an extension method
462540
dotnet_diagnostic.RCS1224.severity = warning
541+
# Make class sealed
542+
dotnet_diagnostic.RCS1225.severity = silent
463543
# Add paragraph to documentation comment
464544
dotnet_diagnostic.RCS1226.severity = warning
465545
# Validate arguments correctly
466546
dotnet_diagnostic.RCS1227.severity = error
467547
# Use async/await when necessary
468548
dotnet_diagnostic.RCS1229.severity = error
549+
# Order elements in documentation comment
550+
dotnet_diagnostic.RCS1232.severity = silent
551+
# Duplicate enum value
552+
dotnet_diagnostic.RCS1234.severity = silent
469553
# Use exception filter
470554
dotnet_diagnostic.RCS1236.severity = warning
471555
# Operator is unnecessary
@@ -476,16 +560,26 @@ dotnet_diagnostic.RCS1242.severity = silent
476560
dotnet_diagnostic.RCS1243.severity = warning
477561
# Use element access
478562
dotnet_diagnostic.RCS1246.severity = warning
563+
# Fix documentation comment tag
564+
dotnet_diagnostic.RCS1247.severity = silent # redundant with DOC203
479565
# Unnecessary null-forgiving operator
480566
dotnet_diagnostic.RCS1249.severity = warning
567+
# Normalize format of enum flag value
568+
dotnet_diagnostic.RCS1254.severity = silent
481569
# Invalid argument null check
482570
dotnet_diagnostic.RCS1256.severity = error
483571
# Use enum field explicitly
484572
dotnet_diagnostic.RCS1257.severity = warning
485573
# Unnecessary enum flag
486574
dotnet_diagnostic.RCS1258.severity = warning
575+
# Remove empty syntax
576+
dotnet_diagnostic.RCS1259.severity = silent # `else`/`finally` redundant with MA0090, `;;` redundant with MA0037, obj. init. doesn't work, others useless
487577
# Resource can be disposed asynchronously
488578
dotnet_diagnostic.RCS1261.severity = error
579+
# Unnecessary raw string literal
580+
dotnet_diagnostic.RCS1262.severity = silent
581+
# Invalid reference in a documentation comment
582+
dotnet_diagnostic.RCS1263.severity = silent # redundant with CS1572
489583

490584
## Microsoft.CodeAnalysis.BannedApiAnalyzers rules
491585

0 commit comments

Comments
 (0)