Skip to content

Commit 070e703

Browse files
committed
Ensure there can be no edge cases involving SGXCD sysID
breaks config, in case you care about setting a custom save dir for PCE
1 parent 3d42b19 commit 070e703

File tree

6 files changed

+10
-2
lines changed

6 files changed

+10
-2
lines changed

src/BizHawk.Client.Common/config/Config.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public class Config
3636
new[] { CoreNames.Gambatte, CoreNames.Sameboy, CoreNames.GbHawk, CoreNames.SubGbHawk }),
3737
(new[] { VSystemID.Raw.GBL },
3838
new[] { CoreNames.GambatteLink, CoreNames.GBHawkLink, CoreNames.GBHawkLink3x, CoreNames.GBHawkLink4x }),
39-
(new[] { VSystemID.Raw.PCE, VSystemID.Raw.PCECD, VSystemID.Raw.SGX },
39+
(new[] { VSystemID.Raw.PCE, VSystemID.Raw.PCECD, VSystemID.Raw.SGX, VSystemID.Raw.SGXCD },
4040
new[] { CoreNames.TurboNyma, CoreNames.HyperNyma, CoreNames.PceHawk }),
4141
(new[] { VSystemID.Raw.PSX },
4242
new[] { CoreNames.Octoshock, CoreNames.Nymashock }),
@@ -329,6 +329,7 @@ public void ResolveDefaults()
329329
[VSystemID.Raw.PCE] = CoreNames.TurboNyma,
330330
[VSystemID.Raw.PCECD] = CoreNames.TurboNyma,
331331
[VSystemID.Raw.SGX] = CoreNames.TurboNyma,
332+
[VSystemID.Raw.SGXCD] = CoreNames.TurboNyma,
332333
[VSystemID.Raw.PSX] = CoreNames.Nymashock,
333334
[VSystemID.Raw.TI83] = CoreNames.Emu83,
334335
};

src/BizHawk.Client.Common/config/PathEntryCollection.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public class PathEntryCollection : IEnumerable<PathEntry>
1515
{
1616
private static readonly string COMBINED_SYSIDS_GB = string.Join("_", VSystemID.Raw.GB, VSystemID.Raw.GBC, VSystemID.Raw.SGB);
1717

18-
private static readonly string COMBINED_SYSIDS_PCE = string.Join("_", VSystemID.Raw.PCE, VSystemID.Raw.PCECD, VSystemID.Raw.SGX);
18+
private static readonly string COMBINED_SYSIDS_PCE = string.Join("_", VSystemID.Raw.PCE, VSystemID.Raw.PCECD, VSystemID.Raw.SGX, VSystemID.Raw.SGXCD);
1919

2020
public static readonly string GLOBAL = string.Join("_", "Global", VSystemID.Raw.NULL);
2121

src/BizHawk.Emulation.Cores/Consoles/NEC/PCE/HyperNyma.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ public static NymaSettingsInfo CachedSettingsInfo(CoreComm comm)
3838
[CoreConstructor(VSystemID.Raw.PCE, Priority = CorePriority.Low)]
3939
[CoreConstructor(VSystemID.Raw.SGX, Priority = CorePriority.Low)]
4040
[CoreConstructor(VSystemID.Raw.PCECD, Priority = CorePriority.Low)]
41+
[CoreConstructor(VSystemID.Raw.SGXCD, Priority = CorePriority.Low)]
4142
public HyperNyma(CoreLoadParameters<NymaSettings, NymaSyncSettings> lp)
4243
: base(lp.Comm, VSystemID.Raw.PCE, "PC Engine Controller", lp.Settings, lp.SyncSettings)
4344
{

src/BizHawk.Emulation.Cores/Consoles/NEC/PCE/TurboNyma.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ public static NymaSettingsInfo CachedSettingsInfo(CoreComm comm)
4040
[CoreConstructor(VSystemID.Raw.PCE)]
4141
[CoreConstructor(VSystemID.Raw.SGX)]
4242
[CoreConstructor(VSystemID.Raw.PCECD)]
43+
[CoreConstructor(VSystemID.Raw.SGXCD)]
4344
public TurboNyma(CoreLoadParameters<NymaSettings, NymaSyncSettings> lp)
4445
: base(lp.Comm, VSystemID.Raw.PCE, "PC Engine Controller", lp.Settings, lp.SyncSettings)
4546
{

src/BizHawk.Emulation.Cores/Consoles/PC Engine/PCEngine.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ public sealed partial class PCEngine : IEmulator, ISaveRam, IInputPollable, IVid
2323
[CoreConstructor(VSystemID.Raw.PCE, Priority = CorePriority.Low)]
2424
[CoreConstructor(VSystemID.Raw.SGX, Priority = CorePriority.Low)]
2525
[CoreConstructor(VSystemID.Raw.PCECD, Priority = CorePriority.Low)]
26+
[CoreConstructor(VSystemID.Raw.SGXCD, Priority = CorePriority.Low)]
2627
public PCEngine(CoreLoadParameters<PCESettings, PCESyncSettings> lp)
2728
{
2829
if (lp.Discs.Count == 1 && lp.Roms.Count == 0)

src/BizHawk.Emulation.Cores/vpads_schemata/PceSchema.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@
1010

1111
namespace BizHawk.Emulation.Cores
1212
{
13+
[Schema(VSystemID.Raw.SGXCD)]
14+
// ReSharper disable once UnusedMember.Global
15+
public class SgxCdSchema : PceSchema { }
16+
1317
[Schema(VSystemID.Raw.PCECD)]
1418
// ReSharper disable once UnusedMember.Global
1519
public class PceCdSchema : PceSchema { }

0 commit comments

Comments
 (0)