-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ST6RI-727 Implicit redefinitions should be added even if there are owned redefinitions #525
Conversation
- Only create new parameters on the invocation for parameters that have value Expressions on the original invocation.
- See also KERML-308.
@himi |
I think so. The visualizer currently uses owned redefinitions only. I can check it for sure with some tricky examples. But if you'd like to complete it quickly, please do so without my review. |
@himi |
@seidewitz, thank you for letting me know about it. I'll do so. This PR itself looks quite reasonable because SysML/KerML parameters are positional as you previously said. |
@himi |
FeatureAdapter::isComputeRedefinitions
so that implicit redefinitions are added even if aFeature
already hasownedRedefinitions
, consistent with the rules for implied redefinitions per the specifications.ownedRedefinitions
. See alsoTradeStudies::TradeStudy
model per the resolution to the issue below (because otherwise the above changes result in validation errors being flagged for the model).