MDL-85811 user_profile: fix capability checks for viewing user details

Supporting teacher view

Author: AviMoto

user/profile/lib.php

@@ -471,10 +471,9 @@ public function is_visible(?context $context = null): bool {
                 } else if ($this->userid == $USER->id) {
                     return true;
                 } else if ($this->userid > 0) {
-                    return has_capability('moodle/user:viewalldetails', $context);
-                } else {
                     $coursecontext = context_course::instance($COURSE->id);
-                    return has_capability('moodle/site:viewuseridentity', $coursecontext);
+                    return has_capability('moodle/site:viewuseridentity', $coursecontext) ||
+                        has_capability('moodle/user:viewalldetails', $context);
                 }
             case PROFILE_VISIBLE_ALL:
                 return true;