Skip to content

Robust ovm prod tests #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 13, 2021
Merged

Robust ovm prod tests #1130

merged 13 commits into from
Mar 13, 2021

Conversation

i-stam
Copy link
Contributor

@i-stam i-stam commented Mar 5, 2021

This PR refactors and extends the SynthExchange ovm prod tests to make them more robust:

  • Modular, "behaviour" based implementation.
  • No assumption about the value of the waiting period.

@i-stam i-stam marked this pull request as draft March 5, 2021 12:17
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #1130 (3c4a024) into develop (468a28b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1130   +/-   ##
========================================
  Coverage    95.62%   95.62%           
========================================
  Files           76       76           
  Lines         5413     5413           
  Branches       661      661           
========================================
  Hits          5176     5176           
  Misses         237      237           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 468a28b...3c4a024. Read the comment docs.

@i-stam i-stam marked this pull request as ready for review March 9, 2021 13:39
@i-stam i-stam merged commit 59ee2b7 into develop Mar 13, 2021
@i-stam i-stam deleted the update-optimism-prod-tests branch March 13, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants