Skip to content

Commit

Permalink
[Blackfin] arch: Give the DMA base registers a more descriptive name
Browse files Browse the repository at this point in the history
The DMA base registers are available in a global named "base_addr" for
every Blackfin variant. Give this a more descriptive name, and remove
duplicate tables from some drivers.

Signed-off-by: Bernd Schmidt <bernds_cb1@t-online.de>
Signed-off-by: Bryan Wu <cooloney@kernel.org>
  • Loading branch information
bernds authored and Bryan Wu committed Apr 23, 2008
1 parent ac86a97 commit 7795566
Show file tree
Hide file tree
Showing 12 changed files with 14 additions and 25 deletions.
2 changes: 1 addition & 1 deletion arch/blackfin/kernel/bfin_dma_5xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ static int __init blackfin_dma_init(void)

for (i = 0; i < MAX_BLACKFIN_DMA_CHANNEL; i++) {
dma_ch[i].chan_status = DMA_CHANNEL_FREE;
dma_ch[i].regs = base_addr[i];
dma_ch[i].regs = dma_io_base_addr[i];
mutex_init(&(dma_ch[i].dmalock));
}
/* Mark MEMDMA Channel 0 as requested since we're using it internally */
Expand Down
4 changes: 2 additions & 2 deletions arch/blackfin/mach-bf527/dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
#include <asm/blackfin.h>
#include <asm/dma.h>

struct dma_register *base_addr[MAX_BLACKFIN_DMA_CHANNEL] = {
struct dma_register *dma_io_base_addr[MAX_BLACKFIN_DMA_CHANNEL] = {
(struct dma_register *) DMA0_NEXT_DESC_PTR,
(struct dma_register *) DMA1_NEXT_DESC_PTR,
(struct dma_register *) DMA2_NEXT_DESC_PTR,
Expand All @@ -49,7 +49,7 @@ struct dma_register *base_addr[MAX_BLACKFIN_DMA_CHANNEL] = {
(struct dma_register *) MDMA_D1_NEXT_DESC_PTR,
(struct dma_register *) MDMA_S1_NEXT_DESC_PTR,
};
EXPORT_SYMBOL(base_addr);
EXPORT_SYMBOL(dma_io_base_addr);

int channel2irq(unsigned int channel)
{
Expand Down
4 changes: 2 additions & 2 deletions arch/blackfin/mach-bf533/dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
#include <asm/blackfin.h>
#include <asm/dma.h>

struct dma_register *base_addr[MAX_BLACKFIN_DMA_CHANNEL] = {
struct dma_register *dma_io_base_addr[MAX_BLACKFIN_DMA_CHANNEL] = {
(struct dma_register *) DMA0_NEXT_DESC_PTR,
(struct dma_register *) DMA1_NEXT_DESC_PTR,
(struct dma_register *) DMA2_NEXT_DESC_PTR,
Expand All @@ -45,7 +45,7 @@ struct dma_register *base_addr[MAX_BLACKFIN_DMA_CHANNEL] = {
(struct dma_register *) MDMA_D1_NEXT_DESC_PTR,
(struct dma_register *) MDMA_S1_NEXT_DESC_PTR,
};
EXPORT_SYMBOL(base_addr);
EXPORT_SYMBOL(dma_io_base_addr);

int channel2irq(unsigned int channel)
{
Expand Down
4 changes: 2 additions & 2 deletions arch/blackfin/mach-bf537/dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
#include <asm/blackfin.h>
#include <asm/dma.h>

struct dma_register *base_addr[MAX_BLACKFIN_DMA_CHANNEL] = {
struct dma_register *dma_io_base_addr[MAX_BLACKFIN_DMA_CHANNEL] = {
(struct dma_register *) DMA0_NEXT_DESC_PTR,
(struct dma_register *) DMA1_NEXT_DESC_PTR,
(struct dma_register *) DMA2_NEXT_DESC_PTR,
Expand All @@ -49,7 +49,7 @@ struct dma_register *base_addr[MAX_BLACKFIN_DMA_CHANNEL] = {
(struct dma_register *) MDMA_D1_NEXT_DESC_PTR,
(struct dma_register *) MDMA_S1_NEXT_DESC_PTR,
};
EXPORT_SYMBOL(base_addr);
EXPORT_SYMBOL(dma_io_base_addr);

int channel2irq(unsigned int channel)
{
Expand Down
4 changes: 2 additions & 2 deletions arch/blackfin/mach-bf548/dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
#include <asm/blackfin.h>
#include <asm/dma.h>

struct dma_register *base_addr[MAX_BLACKFIN_DMA_CHANNEL] = {
struct dma_register *dma_io_base_addr[MAX_BLACKFIN_DMA_CHANNEL] = {
(struct dma_register *) DMA0_NEXT_DESC_PTR,
(struct dma_register *) DMA1_NEXT_DESC_PTR,
(struct dma_register *) DMA2_NEXT_DESC_PTR,
Expand Down Expand Up @@ -66,7 +66,7 @@ struct dma_register *base_addr[MAX_BLACKFIN_DMA_CHANNEL] = {
(struct dma_register *) MDMA_D3_NEXT_DESC_PTR,
(struct dma_register *) MDMA_S3_NEXT_DESC_PTR,
};
EXPORT_SYMBOL(base_addr);
EXPORT_SYMBOL(dma_io_base_addr);

int channel2irq(unsigned int channel)
{
Expand Down
4 changes: 2 additions & 2 deletions arch/blackfin/mach-bf561/dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
#include <asm/blackfin.h>
#include <asm/dma.h>

struct dma_register *base_addr[MAX_BLACKFIN_DMA_CHANNEL] = {
struct dma_register *dma_io_base_addr[MAX_BLACKFIN_DMA_CHANNEL] = {
(struct dma_register *) DMA1_0_NEXT_DESC_PTR,
(struct dma_register *) DMA1_1_NEXT_DESC_PTR,
(struct dma_register *) DMA1_2_NEXT_DESC_PTR,
Expand Down Expand Up @@ -69,7 +69,7 @@ struct dma_register *base_addr[MAX_BLACKFIN_DMA_CHANNEL] = {
(struct dma_register *) IMDMA_D1_NEXT_DESC_PTR,
(struct dma_register *) IMDMA_S1_NEXT_DESC_PTR,
};
EXPORT_SYMBOL(base_addr);
EXPORT_SYMBOL(dma_io_base_addr);

int channel2irq(unsigned int channel)
{
Expand Down
3 changes: 3 additions & 0 deletions include/asm-blackfin/dma.h
Original file line number Diff line number Diff line change
Expand Up @@ -191,4 +191,7 @@ void clear_dma_irqstat(unsigned int channel);
void *dma_memcpy(void *dest, const void *src, size_t count);
void *safe_dma_memcpy(void *dest, const void *src, size_t count);

extern int channel2irq(unsigned int channel);
extern struct dma_register *dma_io_base_addr[MAX_BLACKFIN_DMA_CHANNEL];

#endif
3 changes: 0 additions & 3 deletions include/asm-blackfin/mach-bf527/dma.h
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,4 @@
#define CH_NFC CH_EMAC_TX /* PPI receive/transmit or NFC */
#endif

extern int channel2irq(unsigned int channel);
extern struct dma_register *base_addr[];

#endif
3 changes: 0 additions & 3 deletions include/asm-blackfin/mach-bf533/dma.h
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,4 @@
#define CH_MEM_STREAM1_DEST 10 /* TX */
#define CH_MEM_STREAM1_SRC 11 /* RX */

extern int channel2irq(unsigned int channel);
extern struct dma_register *base_addr[];

#endif
3 changes: 0 additions & 3 deletions include/asm-blackfin/mach-bf537/dma.h
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,4 @@
#define CH_MEM_STREAM1_DEST 14 /* TX */
#define CH_MEM_STREAM1_SRC 15 /* RX */

extern int channel2irq(unsigned int channel);
extern struct dma_register *base_addr[];

#endif
2 changes: 0 additions & 2 deletions include/asm-blackfin/mach-bf548/dma.h
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,4 @@

#define MAX_BLACKFIN_DMA_CHANNEL 32

extern int channel2irq(unsigned int channel);
extern struct dma_register *base_addr[MAX_BLACKFIN_DMA_CHANNEL];
#endif
3 changes: 0 additions & 3 deletions include/asm-blackfin/mach-bf561/dma.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,4 @@
#define CH_IMEM_STREAM1_SRC 34
#define CH_IMEM_STREAM1_DEST 35

extern int channel2irq(unsigned int channel);
extern struct dma_register *base_addr[];

#endif

0 comments on commit 7795566

Please sign in to comment.