Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image controls error handling #22

Open
BobDickinson opened this issue Aug 15, 2014 · 0 comments
Open

Image controls error handling #22

BobDickinson opened this issue Aug 15, 2014 · 0 comments

Comments

@BobDickinson
Copy link
Member

The image controls (all platforms) take a "resource" parameter, which is a URL pointing to an image resource. If this fails in any way (badly formed URL, destination unreachable, download failed, etc), the client freaks out in a pretty spectacular way (spontaneous shutdown, generally).

Anyway, these all need to be reviewed and tested. The appropriate behavior is probably to just fail (eat the exception) and not show an image. Maybe log this somewhere?

Maybe we should have a backup/default image attribute (for when the supplied image fails), or maybe we should have some kind of "broken image" image that we show in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant