Improve tests of extension

Author: MilesCranmer

ext/DynamicQuantitiesUnitfulExt.jl

@@ -52,7 +52,7 @@ Base.convert(::Type{DynamicQuantities.Dimensions}, d::Unitful.Dimensions{D}) whe
 
 Base.convert(::Type{DynamicQuantities.Dimensions}, x::Unitful.FreeUnits) =
     let
-        dimension(convert(Unitful.Quantity, x))
+        DynamicQuantities.dimension(convert(DynamicQuantities.Quantity, x))
     end
 
 function _map_dim_name_to_dynamic_units(::Type{Unitful.Dimension{D}}) where {D}
@@ -64,7 +64,7 @@ function _map_dim_name_to_dynamic_units(::Type{Unitful.Dimension{D}}) where {D}
     D == :Temperature && return :temperature
     D == :Luminosity && return :luminosity
     D == :Amount && return :amount
-    error("Unknown dimension: $D")
+    throw(error("Unknown dimension: $D. Valid dimensions are: (:Length, :Mass, :Time, :Current, :Temperature, :Luminosity, :Amount)."))
 end
 
 

test/unitful.jl

@@ -8,3 +8,14 @@ x_unitful = 0.2u"mol^2*A^(-1//2)*cd^(2//5)"
 
 @test convert(Unitful.Quantity, x) ≈ x_unitful
 @test convert(DynamicQuantities.Quantity, convert(Unitful.Quantity, x)) ≈ x
+
+@test convert(DynamicQuantities.Quantity, u"c") ≈ 2.99792458e8 * DynamicQuantities.Dimensions(length=1, time=-1)
+@test convert(DynamicQuantities.Dimensions, u"c") == DynamicQuantities.Dimensions(length=1, time=-1)
+@test convert(DynamicQuantities.Dimensions, Unitful.dimension(u"c")) == DynamicQuantities.Dimensions(length=1, time=-1)
+
+# Defining a custom dimension should throw an error:
+Unitful.@dimension 𝚾 "𝚾" MyDimension
+# @refunit m "m" Meter 𝐋 true
+Unitful.@refunit my_unit "x" MyDimension 𝚾 true
+
+@test_throws "Unknown dimension: MyDimension" convert(DynamicQuantities.Quantity, 1.0 * my_unit)